Source/core/editing/markup.cpp - Issue 428533006: Use ContainerNode::hasChildren() instead of firstChild() in conditionals

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/markup.cpp

Issue 428533006: Use ContainerNode::hasChildren() instead of firstChild() in conditionals (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: build fix Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/editing/markup.cpp

diff --git a/Source/core/editing/markup.cpp b/Source/core/editing/markup.cpp

index 58647b1018def31885d511f5a29f2c1161aa18ba..efb90bfbbaba741986c4f28e3b4efa0e0c18a842 100644

--- a/Source/core/editing/markup.cpp

+++ b/Source/core/editing/markup.cpp

@@ -816,7 +816,7 @@ bool isPlainTextMarkup(Node* node)

if (!isHTMLDivElement(*element) || !element->hasAttributes())

return false;

- if (element->hasOneChild() && (element->firstChild()->isTextNode() || (element->firstChild()->firstChild())))

+ if (element->hasOneChild() && (element->firstChild()->isTextNode() || element->firstChild()->hasChildren()))

return true;

return element->hasChildCount(2) && isTabSpanTextNode(element->firstChild()->firstChild()) && element->lastChild()->isTextNode();