Source/core/html/shadow/DateTimeEditElement.cpp - Issue 428533006: Use ContainerNode::hasChildren() instead of firstChild() in conditionals

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/shadow/DateTimeEditElement.cpp

Issue 428533006: Use ContainerNode::hasChildren() instead of firstChild() in conditionals (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: build fix Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/shadow/DateTimeEditElement.cpp

diff --git a/Source/core/html/shadow/DateTimeEditElement.cpp b/Source/core/html/shadow/DateTimeEditElement.cpp

index 1e77dd76dc890f9627f7a77722feb72c93504253..11bfb528260be3187bcd7ef01486cd0c8edbaabb 100644

--- a/Source/core/html/shadow/DateTimeEditElement.cpp

+++ b/Source/core/html/shadow/DateTimeEditElement.cpp

@@ -662,7 +662,7 @@ bool DateTimeEditElement::isReadOnly() const

void DateTimeEditElement::layout(const LayoutParameters& layoutParameters, const DateComponents& dateValue)

{

DEFINE_STATIC_LOCAL(AtomicString, fieldsWrapperPseudoId, ("-webkit-datetime-edit-fields-wrapper", AtomicString::ConstructFromLiteral));

- if (!firstChild()) {

+ if (!hasChildren()) {

RefPtrWillBeRawPtr<HTMLDivElement> element = HTMLDivElement::create(document());

element->setShadowPseudoId(fieldsWrapperPseudoId);

appendChild(element.get());