Source/core/editing/TypingCommand.cpp - Issue 428533006: Use ContainerNode::hasChildren() instead of firstChild() in conditionals

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/TypingCommand.cpp

Issue 428533006: Use ContainerNode::hasChildren() instead of firstChild() in conditionals (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: build fix Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/editing/TypingCommand.cpp

diff --git a/Source/core/editing/TypingCommand.cpp b/Source/core/editing/TypingCommand.cpp

index 4ad36ee8040a438a9337cac9b0d054cd00cb5c22..694404ee9587a537efe5578f3c221ab9b302131c 100644

--- a/Source/core/editing/TypingCommand.cpp

+++ b/Source/core/editing/TypingCommand.cpp

@@ -386,7 +386,7 @@ void TypingCommand::insertParagraphSeparatorInQuotedContent()

bool TypingCommand::makeEditableRootEmpty()

{

Element* root = endingSelection().rootEditableElement();

- if (!root || !root->firstChild())

+ if (!root || !root->hasChildren())

return false;

if (root->firstChild() == root->lastChild()) {

« no previous file with comments | « Source/core/editing/SpellChecker.cpp ('k') | Source/core/editing/markup.cpp » ('j') | no next file with comments »