Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Side by Side Diff: Source/core/svg/SVGTitleElement.cpp

Issue 428533006: Use ContainerNode::hasChildren() instead of firstChild() in conditionals (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: build fix Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/inspector/DOMPatchSupport.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2006 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2006 Rob Buis <buis@kde.org>
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 21 matching lines...) Expand all
32 ScriptWrappable::init(this); 32 ScriptWrappable::init(this);
33 } 33 }
34 34
35 DEFINE_NODE_FACTORY(SVGTitleElement) 35 DEFINE_NODE_FACTORY(SVGTitleElement)
36 36
37 Node::InsertionNotificationRequest SVGTitleElement::insertedInto(ContainerNode* rootParent) 37 Node::InsertionNotificationRequest SVGTitleElement::insertedInto(ContainerNode* rootParent)
38 { 38 {
39 SVGElement::insertedInto(rootParent); 39 SVGElement::insertedInto(rootParent);
40 if (!rootParent->inDocument()) 40 if (!rootParent->inDocument())
41 return InsertionDone; 41 return InsertionDone;
42 if (firstChild() && document().isSVGDocument()) 42 if (hasChildren() && document().isSVGDocument())
43 document().setTitleElement(this); 43 document().setTitleElement(this);
44 return InsertionDone; 44 return InsertionDone;
45 } 45 }
46 46
47 void SVGTitleElement::removedFrom(ContainerNode* rootParent) 47 void SVGTitleElement::removedFrom(ContainerNode* rootParent)
48 { 48 {
49 SVGElement::removedFrom(rootParent); 49 SVGElement::removedFrom(rootParent);
50 if (rootParent->inDocument() && document().isSVGDocument()) 50 if (rootParent->inDocument() && document().isSVGDocument())
51 document().removeTitle(this); 51 document().removeTitle(this);
52 } 52 }
53 53
54 void SVGTitleElement::childrenChanged(const ChildrenChange& change) 54 void SVGTitleElement::childrenChanged(const ChildrenChange& change)
55 { 55 {
56 SVGElement::childrenChanged(change); 56 SVGElement::childrenChanged(change);
57 if (inDocument() && document().isSVGDocument()) 57 if (inDocument() && document().isSVGDocument())
58 document().setTitleElement(this); 58 document().setTitleElement(this);
59 } 59 }
60 60
61 } 61 }
OLDNEW
« no previous file with comments | « Source/core/inspector/DOMPatchSupport.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698