Source/core/dom/ScriptLoader.cpp - Issue 428533006: Use ContainerNode::hasChildren() instead of firstChild() in conditionals

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/ScriptLoader.cpp

Issue 428533006: Use ContainerNode::hasChildren() instead of firstChild() in conditionals (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: build fix Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/dom/ScriptLoader.cpp

diff --git a/Source/core/dom/ScriptLoader.cpp b/Source/core/dom/ScriptLoader.cpp

index edab8357141e7ba6def91fd8e3f6ea6c50df2593..b528db782701930d24d8b428158fbd67c40a3150 100644

--- a/Source/core/dom/ScriptLoader.cpp

+++ b/Source/core/dom/ScriptLoader.cpp

@@ -184,7 +184,7 @@ bool ScriptLoader::prepareScript(const TextPosition& scriptStartPosition, Legacy

m_forceAsync = true;

// FIXME: HTML5 spec says we should check that all children are either comments or empty text nodes.

- if (!client->hasSourceAttribute() && !m_element->firstChild())

+ if (!client->hasSourceAttribute() && !m_element->hasChildren())

return false;

if (!m_element->inDocument())

« no previous file with comments | « Source/core/dom/Position.cpp ('k') | Source/core/dom/TreeWalker.cpp » ('j') | no next file with comments »