Source/core/accessibility/AXRenderObject.cpp - Issue 428533006: Use ContainerNode::hasChildren() instead of firstChild() in conditionals

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/accessibility/AXRenderObject.cpp

Issue 428533006: Use ContainerNode::hasChildren() instead of firstChild() in conditionals (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: build fix Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/accessibility/AXRenderObject.cpp

diff --git a/Source/core/accessibility/AXRenderObject.cpp b/Source/core/accessibility/AXRenderObject.cpp

index 691af627e14e868d72ca0625be96a2ee114cd7ee..a3106b22c7cba331614e7dc8e9cbf8efd4923b1f 100644

--- a/Source/core/accessibility/AXRenderObject.cpp

+++ b/Source/core/accessibility/AXRenderObject.cpp

@@ -749,7 +749,7 @@ bool AXRenderObject::computeAccessibilityIsIgnored() const

// Don't ignore generic focusable elements like <div tabindex=0>

// unless they're completely empty, with no children.

- if (isGenericFocusableElement() && node->firstChild())

+ if (isGenericFocusableElement() && node->hasChildren())

return false;

if (!ariaAccessibilityDescription().isEmpty())

« no previous file with comments | « no previous file | Source/core/dom/Node.cpp » ('j') | no next file with comments »