Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 371923006: Add mips64 port. (Closed)

Created:
6 years, 5 months ago by dusmil
Modified:
6 years, 5 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Add mips64 port. Summary: - Changes in common code are mainly boilerplate changes, gyp and test status files updates. - On mips64 simulator all tests pass from all test units. - Current issues: mjsunit JS debugger tests fail randomly on HW in release mode. Corresponding tests are skipped on HW. - Skipped tests on mips64: test-heap/ReleaseOverReservedPages, mjsunit/debug-* TEST= BUG= R=danno@chromium.org, plind44@gmail.com, ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22297

Patch Set 1 #

Patch Set 2 : Remove clobbered test-assembler-mips from CL. #

Total comments: 7

Patch Set 3 : Rebase #

Patch Set 4 : Comments addressed #

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6896 lines, -4880 lines) Patch
M Makefile View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M build/detect_v8_host_arch.py View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M build/standalone.gypi View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M build/toolchain.gypi View 1 2 3 4 6 chunks +66 lines, -7 lines 0 comments Download
M src/assembler.cc View 1 2 3 4 3 chunks +6 lines, -0 lines 0 comments Download
M src/base/atomicops.h View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
A src/base/atomicops_internals_mips64_gcc.h View 1 2 3 4 1 chunk +307 lines, -0 lines 0 comments Download
M src/base/build_config.h View 1 2 3 4 6 chunks +14 lines, -1 line 0 comments Download
M src/base/cpu.cc View 1 2 3 4 4 chunks +5 lines, -4 lines 0 comments Download
M src/base/platform/platform-posix.cc View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M src/code-stubs.h View 1 2 3 4 2 chunks +8 lines, -0 lines 0 comments Download
M src/codegen.h View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M src/flag-definitions.h View 1 2 3 4 2 chunks +3 lines, -2 lines 0 comments Download
M src/frames-inl.h View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M src/full-codegen.h View 1 2 3 4 2 chunks +10 lines, -0 lines 0 comments Download
M src/gdb-jit.cc View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M src/globals.h View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M src/heap.cc View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M src/hydrogen.cc View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M src/isolate.h View 1 2 3 4 5 chunks +10 lines, -5 lines 0 comments Download
M src/isolate.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M src/jsregexp.cc View 1 2 3 4 2 chunks +5 lines, -0 lines 0 comments Download
M src/lithium.cc View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M src/lithium-allocator.cc View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M src/lithium-allocator-inl.h View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M src/lithium-codegen.cc View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M src/macro-assembler.h View 1 2 3 4 1 chunk +7 lines, -0 lines 0 comments Download
A + src/mips64/OWNERS View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/mips64/assembler-mips64.h View 1 2 3 4 24 chunks +74 lines, -50 lines 0 comments Download
A + src/mips64/assembler-mips64.cc View 1 2 3 4 45 chunks +344 lines, -210 lines 0 comments Download
A + src/mips64/assembler-mips64-inl.h View 1 2 3 4 8 chunks +29 lines, -22 lines 0 comments Download
A + src/mips64/builtins-mips64.cc View 1 2 3 4 66 chunks +338 lines, -322 lines 0 comments Download
A + src/mips64/code-stubs-mips64.h View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
A + src/mips64/code-stubs-mips64.cc View 1 2 3 4 138 chunks +787 lines, -749 lines 0 comments Download
A + src/mips64/codegen-mips64.h View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/mips64/codegen-mips64.cc View 1 2 3 4 34 chunks +315 lines, -425 lines 0 comments Download
A + src/mips64/constants-mips64.h View 1 2 3 4 14 chunks +84 lines, -29 lines 0 comments Download
A + src/mips64/constants-mips64.cc View 1 2 3 4 7 chunks +27 lines, -5 lines 0 comments Download
A + src/mips64/cpu-mips64.cc View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
A + src/mips64/debug-mips64.cc View 1 2 3 4 9 chunks +48 lines, -44 lines 0 comments Download
A + src/mips64/deoptimizer-mips64.cc View 1 2 3 4 13 chunks +57 lines, -53 lines 0 comments Download
A + src/mips64/disasm-mips64.cc View 1 2 3 4 19 chunks +155 lines, -44 lines 0 comments Download
A + src/mips64/frames-mips64.h View 1 2 3 4 2 chunks +16 lines, -16 lines 0 comments Download
A + src/mips64/frames-mips64.cc View 1 2 3 4 2 chunks +5 lines, -4 lines 0 comments Download
A + src/mips64/full-codegen-mips64.cc View 1 2 3 4 125 chunks +377 lines, -380 lines 0 comments Download
A + src/mips64/ic-mips64.cc View 1 2 3 4 41 chunks +184 lines, -175 lines 0 comments Download
A + src/mips64/lithium-codegen-mips64.h View 1 2 3 4 2 chunks +4 lines, -3 lines 0 comments Download
A + src/mips64/lithium-codegen-mips64.cc View 1 2 3 4 138 chunks +472 lines, -414 lines 0 comments Download
A + src/mips64/lithium-gap-resolver-mips64.h View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/mips64/lithium-gap-resolver-mips64.cc View 1 2 3 4 7 chunks +24 lines, -23 lines 0 comments Download
A + src/mips64/lithium-mips64.h View 1 2 3 4 3 chunks +1 line, -17 lines 0 comments Download
A + src/mips64/lithium-mips64.cc View 1 2 3 4 12 chunks +17 lines, -18 lines 0 comments Download
A + src/mips64/macro-assembler-mips64.h View 1 2 3 4 21 chunks +150 lines, -66 lines 0 comments Download
A + src/mips64/macro-assembler-mips64.cc View 1 2 3 4 191 chunks +883 lines, -696 lines 0 comments Download
A + src/mips64/regexp-macro-assembler-mips64.h View 1 2 3 4 6 chunks +52 lines, -9 lines 0 comments Download
A + src/mips64/regexp-macro-assembler-mips64.cc View 1 2 3 4 54 chunks +219 lines, -174 lines 0 comments Download
A + src/mips64/simulator-mips64.h View 1 2 3 4 10 chunks +107 lines, -44 lines 0 comments Download
A + src/mips64/simulator-mips64.cc View 1 2 3 4 111 chunks +723 lines, -342 lines 0 comments Download
A + src/mips64/stub-cache-mips64.cc View 1 2 3 4 44 chunks +97 lines, -96 lines 0 comments Download
M src/objects.h View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M src/objects.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M src/sampler.cc View 1 2 3 4 2 chunks +10 lines, -0 lines 0 comments Download
M src/serialize.cc View 1 2 3 4 2 chunks +4 lines, -2 lines 0 comments Download
M src/simulator.h View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M test/cctest/cctest.gyp View 1 2 3 4 1 chunk +9 lines, -0 lines 0 comments Download
M test/cctest/cctest.status View 1 2 3 4 1 chunk +16 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 1 2 3 4 2 chunks +4 lines, -2 lines 0 comments Download
A + test/cctest/test-assembler-mips64.cc View 1 2 3 4 25 chunks +407 lines, -296 lines 0 comments Download
A + test/cctest/test-code-stubs-mips64.cc View 1 2 3 4 6 chunks +9 lines, -9 lines 0 comments Download
A + test/cctest/test-disasm-mips64.cc View 1 2 3 4 12 chunks +171 lines, -63 lines 0 comments Download
M test/cctest/test-hashing.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/test-heap.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
A + test/cctest/test-macro-assembler-mips64.cc View 1 2 3 4 4 chunks +84 lines, -45 lines 0 comments Download
M test/cctest/test-regexp.cc View 1 2 3 4 2 chunks +7 lines, -0 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 2 3 4 2 chunks +57 lines, -1 line 0 comments Download
M test/mozilla/mozilla.status View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M test/test262/test262.status View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M tools/gyp/v8.gyp View 1 2 3 4 1 chunk +34 lines, -0 lines 0 comments Download
M tools/run-tests.py View 1 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download
M tools/testrunner/local/statusfile.py View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
dusmil
6 years, 5 months ago (2014-07-07 17:10:29 UTC) #1
Paul Lind
The MIPS64 part LGTM.
6 years, 5 months ago (2014-07-07 20:37:56 UTC) #2
danno
Thanks for the patch! Boilerplate changes look generally good, there a few nits I noticed ...
6 years, 5 months ago (2014-07-08 09:01:19 UTC) #3
dusmil
https://codereview.chromium.org/371923006/diff/10001/build/detect_v8_host_arch.py File build/detect_v8_host_arch.py (right): https://codereview.chromium.org/371923006/diff/10001/build/detect_v8_host_arch.py#newcode43 build/detect_v8_host_arch.py:43: host_arch = platform.machine() On 2014/07/08 09:01:19, danno wrote: > ...
6 years, 5 months ago (2014-07-08 11:03:41 UTC) #4
danno
6 years, 5 months ago (2014-07-09 08:54:42 UTC) #5
dusmil
danno, Could we get approval to land this? Previous message was blank.
6 years, 5 months ago (2014-07-09 09:36:49 UTC) #6
danno
Sorry, I added ulan@ to take a look. We're actively reviewing and will let you ...
6 years, 5 months ago (2014-07-09 09:50:12 UTC) #7
dusmil
Ok, great.
6 years, 5 months ago (2014-07-09 10:15:59 UTC) #8
ulan
On 2014/07/09 10:15:59, dusmil wrote: > Ok, great. I reviewed platform-independent changes, and they lgtm.
6 years, 5 months ago (2014-07-09 10:35:47 UTC) #9
danno
OK, lgtm, too. Go ahead and land it. Thanks for the port!
6 years, 5 months ago (2014-07-09 10:58:38 UTC) #10
dusmil
6 years, 5 months ago (2014-07-09 11:09:27 UTC) #11
Message was sent while issue was closed. 
Committed patchset #5 manually as r22297 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698