Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 371103003: Remove GrEffect::CreateEffectRef and GrEffect::AutoEffectRef. (Closed)

Created:
6 years, 5 months ago by bsalomon
Modified:
6 years, 5 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@no_ref2
Visibility:
Public.

Description

Remove GrEffect::CreateEffectRef and GrEffect::AutoEffectRef. Committed: https://skia.googlesource.com/skia/+/55fad7af61c21d502acb9891d631e8aa29e3628c

Patch Set 1 #

Patch Set 2 : wrap line #

Total comments: 6

Patch Set 3 : Address comments and update for new YUV effect #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -206 lines) Patch
M include/gpu/GrEffect.h View 1 chunk +1 line, -23 lines 0 comments Download
M src/core/SkXfermode.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M src/effects/SkAlphaThresholdFilter.cpp View 1 chunk +4 lines, -5 lines 0 comments Download
M src/effects/SkArithmeticMode.cpp View 2 chunks +2 lines, -6 lines 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M src/effects/SkColorFilters.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/effects/SkColorMatrixFilter.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 1 chunk +6 lines, -7 lines 0 comments Download
M src/effects/SkLightingImageFilter.cpp View 2 chunks +11 lines, -13 lines 0 comments Download
M src/effects/SkLumaColorFilter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/effects/SkMagnifierImageFilter.cpp View 1 chunk +7 lines, -8 lines 0 comments Download
M src/effects/SkMatrixConvolutionImageFilter.cpp View 1 chunk +9 lines, -10 lines 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/effects/SkPerlinNoiseShader.cpp View 1 1 chunk +2 lines, -3 lines 0 comments Download
M src/effects/SkTableColorFilter.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/effects/gradients/SkLinearGradient.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/effects/gradients/SkRadialGradient.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/effects/gradients/SkSweepGradient.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient_gpu.cpp View 5 chunks +5 lines, -10 lines 0 comments Download
M src/effects/gradients/SkTwoPointRadialGradient.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/effects/GrBicubicEffect.h View 2 chunks +4 lines, -9 lines 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.cpp View 1 2 3 chunks +21 lines, -27 lines 0 comments Download
M src/gpu/effects/GrConvexPolyEffect.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/effects/GrConvexPolyEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrConvolutionEffect.h View 2 chunks +12 lines, -14 lines 0 comments Download
M src/gpu/effects/GrCustomCoordsTextureEffect.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/effects/GrDashingEffect.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldTextureEffect.h View 2 chunks +7 lines, -11 lines 0 comments Download
M src/gpu/effects/GrDitherEffect.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/effects/GrOvalEffect.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M src/gpu/effects/GrRRectEffect.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M src/gpu/effects/GrSimpleTextureEffect.h View 1 2 2 chunks +4 lines, -7 lines 0 comments Download
M src/gpu/effects/GrTextureDomain.cpp View 1 chunk +6 lines, -8 lines 0 comments Download
M src/gpu/effects/GrYUVtoRGBEffect.cpp View 1 2 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
bsalomon
6 years, 5 months ago (2014-07-07 21:55:40 UTC) #1
robertphillips
lgtm + nits https://codereview.chromium.org/371103003/diff/20001/src/gpu/effects/GrConfigConversionEffect.cpp File src/gpu/effects/GrConfigConversionEffect.cpp (right): https://codereview.chromium.org/371103003/diff/20001/src/gpu/effects/GrConfigConversionEffect.cpp#newcode202 src/gpu/effects/GrConfigConversionEffect.cpp:202: SkAutoTUnref<GrEffect> pmToUPM1(SkNEW_ARGS(GrConfigConversionEffect, (dataTex, Move last 3 ...
6 years, 5 months ago (2014-07-07 22:06:47 UTC) #2
bsalomon
https://codereview.chromium.org/371103003/diff/20001/src/gpu/effects/GrConfigConversionEffect.cpp File src/gpu/effects/GrConfigConversionEffect.cpp (right): https://codereview.chromium.org/371103003/diff/20001/src/gpu/effects/GrConfigConversionEffect.cpp#newcode202 src/gpu/effects/GrConfigConversionEffect.cpp:202: SkAutoTUnref<GrEffect> pmToUPM1(SkNEW_ARGS(GrConfigConversionEffect, (dataTex, On 2014/07/07 22:06:47, robertphillips wrote: > ...
6 years, 5 months ago (2014-07-08 13:54:30 UTC) #3
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 5 months ago (2014-07-08 13:54:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/371103003/40001
6 years, 5 months ago (2014-07-08 13:55:22 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-08 14:34:25 UTC) #6
Message was sent while issue was closed. 
Change committed as 55fad7af61c21d502acb9891d631e8aa29e3628c

Powered by Google App Engine
This is Rietveld 408576698