src/gpu/effects/GrConvexPolyEffect.cpp - Issue 371103003: Remove GrEffect::CreateEffectRef and GrEffect::AutoEffectRef.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/effects/GrConvexPolyEffect.cpp

Issue 371103003: Remove GrEffect::CreateEffectRef and GrEffect::AutoEffectRef. (Closed) Base URL: https://skia.googlesource.com/skia.git@no_ref2

Patch Set: Address comments and update for new YUV effect Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/gpu/effects/GrConvexPolyEffect.cpp

diff --git a/src/gpu/effects/GrConvexPolyEffect.cpp b/src/gpu/effects/GrConvexPolyEffect.cpp

index d24b45e10b5866682512c59f1ea2175c38dcfd1f..aebd5b0b8990ede7d5f0656f4a8b7a01ab330365 100644

--- a/src/gpu/effects/GrConvexPolyEffect.cpp

+++ b/src/gpu/effects/GrConvexPolyEffect.cpp

@@ -25,7 +25,7 @@ public:

static const char* Name() { return "AARect"; }

static GrEffectRef* Create(GrEffectEdgeType edgeType, const SkRect& rect) {

- return CreateEffectRef(AutoEffectUnref(SkNEW_ARGS(AARectEffect, (edgeType, rect))));

+ return SkNEW_ARGS(AARectEffect, (edgeType, rect));

}

virtual void getConstantColorComponents(GrColor* color,

« no previous file with comments | « src/gpu/effects/GrConvexPolyEffect.h ('k') | src/gpu/effects/GrConvolutionEffect.h » ('j') | no next file with comments »