src/effects/SkDisplacementMapEffect.cpp - Issue 371103003: Remove GrEffect::CreateEffectRef and GrEffect::AutoEffectRef.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkDisplacementMapEffect.cpp

Issue 371103003: Remove GrEffect::CreateEffectRef and GrEffect::AutoEffectRef. (Closed) Base URL: https://skia.googlesource.com/skia.git@no_ref2

Patch Set: Address comments and update for new YUV effect Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/SkDisplacementMapEffect.cpp

diff --git a/src/effects/SkDisplacementMapEffect.cpp b/src/effects/SkDisplacementMapEffect.cpp

index a5519d1e9aad44f9310fe67d45122f75180eda66..44c3908779a5e9fa7b16b44512f78a6a3f255422 100644

--- a/src/effects/SkDisplacementMapEffect.cpp

+++ b/src/effects/SkDisplacementMapEffect.cpp

@@ -305,13 +305,12 @@ public:

SkVector scale,

GrTexture* displacement, const SkMatrix& offsetMatrix,

GrTexture* color) {

- AutoEffectUnref effect(SkNEW_ARGS(GrDisplacementMapEffect, (xChannelSelector,

- yChannelSelector,

- scale,

- displacement,

- offsetMatrix,

- color)));

- return CreateEffectRef(effect);

+ return SkNEW_ARGS(GrDisplacementMapEffect, (xChannelSelector,

+ yChannelSelector,

+ scale,

+ displacement,

+ offsetMatrix,

+ color));

}

virtual ~GrDisplacementMapEffect();

« no previous file with comments | « src/effects/SkColorMatrixFilter.cpp ('k') | src/effects/SkLightingImageFilter.cpp » ('j') | no next file with comments »