src/effects/SkTableColorFilter.cpp - Issue 371103003: Remove GrEffect::CreateEffectRef and GrEffect::AutoEffectRef.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkTableColorFilter.cpp

Issue 371103003: Remove GrEffect::CreateEffectRef and GrEffect::AutoEffectRef. (Closed) Base URL: https://skia.googlesource.com/skia.git@no_ref2

Patch Set: Address comments and update for new YUV effect Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/SkTableColorFilter.cpp

diff --git a/src/effects/SkTableColorFilter.cpp b/src/effects/SkTableColorFilter.cpp

index 771d2fa0d30590a6bfedea461fe583b0c05e29de..d4a111e64b512c52b202f55e7d4bf467feff6396 100644

--- a/src/effects/SkTableColorFilter.cpp

+++ b/src/effects/SkTableColorFilter.cpp

@@ -237,8 +237,7 @@ class GLColorTableEffect;

class ColorTableEffect : public GrEffect {

public:

static GrEffectRef* Create(GrTexture* texture, unsigned flags) {

- AutoEffectUnref effect(SkNEW_ARGS(ColorTableEffect, (texture, flags)));

- return CreateEffectRef(effect);

+ return SkNEW_ARGS(ColorTableEffect, (texture, flags));

}

virtual ~ColorTableEffect();

« no previous file with comments | « src/effects/SkPerlinNoiseShader.cpp ('k') | src/effects/gradients/SkLinearGradient.cpp » ('j') | no next file with comments »