Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Side by Side Diff: src/gpu/effects/GrCustomCoordsTextureEffect.h

Issue 371103003: Remove GrEffect::CreateEffectRef and GrEffect::AutoEffectRef. (Closed) Base URL: https://skia.googlesource.com/skia.git@no_ref2
Patch Set: Address comments and update for new YUV effect Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/gpu/effects/GrConvolutionEffect.h ('k') | src/gpu/effects/GrDashingEffect.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2013 Google Inc. 2 * Copyright 2013 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #ifndef GrCustomCoordsTextureEffect_DEFINED 8 #ifndef GrCustomCoordsTextureEffect_DEFINED
9 #define GrCustomCoordsTextureEffect_DEFINED 9 #define GrCustomCoordsTextureEffect_DEFINED
10 10
11 #include "GrEffect.h" 11 #include "GrEffect.h"
12 #include "GrVertexEffect.h" 12 #include "GrVertexEffect.h"
13 13
14 class GrGLCustomCoordsTextureEffect; 14 class GrGLCustomCoordsTextureEffect;
15 15
16 /** 16 /**
17 * The output color of this effect is a modulation of the input color and a samp le from a texture. 17 * The output color of this effect is a modulation of the input color and a samp le from a texture.
18 * It allows explicit specification of the filtering and wrap modes (GrTexturePa rams). The input 18 * It allows explicit specification of the filtering and wrap modes (GrTexturePa rams). The input
19 * coords are a custom attribute. 19 * coords are a custom attribute.
20 */ 20 */
21 class GrCustomCoordsTextureEffect : public GrVertexEffect { 21 class GrCustomCoordsTextureEffect : public GrVertexEffect {
22 public: 22 public:
23 static GrEffectRef* Create(GrTexture* tex, const GrTextureParams& p) { 23 static GrEffectRef* Create(GrTexture* tex, const GrTextureParams& p) {
24 AutoEffectUnref effect(SkNEW_ARGS(GrCustomCoordsTextureEffect, (tex, p)) ); 24 return SkNEW_ARGS(GrCustomCoordsTextureEffect, (tex, p));
25 return CreateEffectRef(effect);
26 } 25 }
27 26
28 virtual ~GrCustomCoordsTextureEffect() {} 27 virtual ~GrCustomCoordsTextureEffect() {}
29 28
30 static const char* Name() { return "Texture"; } 29 static const char* Name() { return "Texture"; }
31 30
32 virtual void getConstantColorComponents(GrColor* color, uint32_t* validFlags ) const SK_OVERRIDE; 31 virtual void getConstantColorComponents(GrColor* color, uint32_t* validFlags ) const SK_OVERRIDE;
33 32
34 typedef GrGLCustomCoordsTextureEffect GLEffect; 33 typedef GrGLCustomCoordsTextureEffect GLEffect;
35 34
36 virtual const GrBackendEffectFactory& getFactory() const SK_OVERRIDE; 35 virtual const GrBackendEffectFactory& getFactory() const SK_OVERRIDE;
37 36
38 private: 37 private:
39 GrCustomCoordsTextureEffect(GrTexture* texture, const GrTextureParams& param s); 38 GrCustomCoordsTextureEffect(GrTexture* texture, const GrTextureParams& param s);
40 39
41 virtual bool onIsEqual(const GrEffect& other) const SK_OVERRIDE; 40 virtual bool onIsEqual(const GrEffect& other) const SK_OVERRIDE;
42 41
43 GrTextureAccess fTextureAccess; 42 GrTextureAccess fTextureAccess;
44 43
45 GR_DECLARE_EFFECT_TEST; 44 GR_DECLARE_EFFECT_TEST;
46 45
47 typedef GrVertexEffect INHERITED; 46 typedef GrVertexEffect INHERITED;
48 }; 47 };
49 48
50 #endif 49 #endif
OLDNEW
« no previous file with comments | « src/gpu/effects/GrConvolutionEffect.h ('k') | src/gpu/effects/GrDashingEffect.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698