Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: include/gpu/GrEffect.h

Issue 371103003: Remove GrEffect::CreateEffectRef and GrEffect::AutoEffectRef. (Closed) Base URL: https://skia.googlesource.com/skia.git@no_ref2
Patch Set: Address comments and update for new YUV effect Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/core/SkXfermode.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/gpu/GrEffect.h
diff --git a/include/gpu/GrEffect.h b/include/gpu/GrEffect.h
index 978ad3a6a661a5fd41d1d463a0b372996921060c..13a6c4308f5ea4cb7deac4b54d770a0283bbe374 100644
--- a/include/gpu/GrEffect.h
+++ b/include/gpu/GrEffect.h
@@ -169,29 +169,7 @@ protected:
, fWillUseInputColor(true)
, fHasVertexCode(false) {}
- /** This should be called by GrEffect subclass factories. See the comment on AutoEffectUnref for
- an example factory function. */
- static GrEffect* CreateEffectRef(GrEffect* effect) {
- return SkRef(effect);
- }
-
- static const GrEffect* CreateEffectRef(const GrEffect* effect) {
- return CreateEffectRef(const_cast<GrEffect*>(effect));
- }
-
- /** Helper used in subclass factory functions to unref the effect after it has been wrapped in a
- GrEffectRef. E.g.:
-
- class EffectSubclass : public GrEffect {
- public:
- GrEffectRef* Create(ParamType1 param1, ParamType2 param2, ...) {
- AutoEffectUnref effect(SkNEW_ARGS(EffectSubclass, (param1, param2, ...)));
- return CreateEffectRef(effect);
- }
- */
- typedef SkAutoTUnref<GrEffect> AutoEffectUnref;
-
- /** Helper for getting the GrEffect out of a GrEffectRef and down-casting to a GrEffect subclass
+ /** Helper for down-casting to a GrEffect subclass
*/
template <typename T>
static const T& CastEffect(const GrEffect& effectRef) {
« no previous file with comments | « no previous file | src/core/SkXfermode.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698