src/effects/gradients/SkTwoPointRadialGradient.cpp - Issue 371103003: Remove GrEffect::CreateEffectRef and GrEffect::AutoEffectRef.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/gradients/SkTwoPointRadialGradient.cpp

Issue 371103003: Remove GrEffect::CreateEffectRef and GrEffect::AutoEffectRef. (Closed) Base URL: https://skia.googlesource.com/skia.git@no_ref2

Patch Set: Address comments and update for new YUV effect Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/gradients/SkTwoPointRadialGradient.cpp

diff --git a/src/effects/gradients/SkTwoPointRadialGradient.cpp b/src/effects/gradients/SkTwoPointRadialGradient.cpp

index 3507c891c0677ec8081360e35d5d0d210c5b5d05..22feb7189c0cd33642e4bc465949f8f8961ac216 100644

--- a/src/effects/gradients/SkTwoPointRadialGradient.cpp

+++ b/src/effects/gradients/SkTwoPointRadialGradient.cpp

@@ -438,8 +438,7 @@ public:

const SkTwoPointRadialGradient& shader,

const SkMatrix& matrix,

SkShader::TileMode tm) {

- AutoEffectUnref effect(SkNEW_ARGS(GrRadial2Gradient, (ctx, shader, matrix, tm)));

- return CreateEffectRef(effect);

+ return SkNEW_ARGS(GrRadial2Gradient, (ctx, shader, matrix, tm));

}

virtual ~GrRadial2Gradient() { }