Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1242)

Issue 2986093002: Revert two Kernel changes that were causing test failures. (Closed)

Created:
3 years, 4 months ago by erikcorry
Modified:
3 years, 4 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert two Kernel changes that were causing test failures. Example failure: python tools/test.py -m release -c dartk --builder-tag no_ipv6 \ language/function_type/function_type63_test Revert "Serialize typedef parameters (including function typed ones) to Kernel and use it to resynthesize typedefs from Kernel." This reverts commit afc392b66d0c0abbc4db2f432ed4b26b3d946920. Reverts https://codereview.chromium.org/2990783002 Revert "Add Member.documentationComment and use it to resynthesize documentation from Kernel." This reverts commit 47ecf72272c6153759758791bb880a4a51ee49a8. Reverts https://codereview.chromium.org/2990873002 Also reverts some attempts to fix test files: 302b4103642687eb10fb751a58d2a09fcf266d16 https://codereview.chromium.org/2984343002 05ccf27015860757b3b6413c75215b3c4ea2b70b https://codereview.chromium.org/2992683002 f71dcd7834a592821d051311befc126d796ab15b https://codereview.chromium.org/2984363003 Also had to revert some test changes that were committed on top of a red buildbot, in order to try to get back to a place where bots were green: 23952fdf56bd83e4ae098b7307fd494b74efa71e https://codereview.chromium.org/2990773002 557cab2a3e2ffa1cc12b9f7b00b1463c30b2f61d https://codereview.chromium.org/2985173002 R=johnniwinther@google.com, karlklose@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/e431e93e872d9a1c97a5177ebb09d5416f1d659a

Patch Set 1 #

Patch Set 2 : Revert "Migrate language/async_backwards... ... language/async_star_take..." #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1217 lines, -3164 lines) Patch
M pkg/analyzer/lib/src/dart/element/element.dart View 11 chunks +8 lines, -54 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_common.dart View 1 chunk +0 lines, -7 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_kernel_test.dart View 10 chunks +110 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/builder/field_builder.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/front_end/lib/src/fasta/builder/member_builder.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/front_end/lib/src/fasta/builder/procedure_builder.dart View 2 chunks +1 line, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/dill/dill_member_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_enum_builder.dart View 3 chunks +6 lines, -24 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_field_builder.dart View 3 chunks +1 line, -4 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_function_type_alias_builder.dart View 5 chunks +3 lines, -28 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_function_type_builder.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart View 7 chunks +2 lines, -16 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_procedure_builder.dart View 8 chunks +6 lines, -29 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_target.dart View 1 chunk +2 lines, -13 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/outline_builder.dart View 5 chunks +2 lines, -12 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/source_library_builder.dart View 4 chunks +4 lines, -7 lines 0 comments Download
M pkg/kernel/lib/ast.dart View 4 chunks +0 lines, -30 lines 0 comments Download
M pkg/kernel/lib/binary/ast_from_binary.dart View 8 chunks +0 lines, -18 lines 0 comments Download
M pkg/kernel/lib/binary/ast_to_binary.dart View 5 chunks +0 lines, -26 lines 0 comments Download
M pkg/kernel/lib/verifier.dart View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/kernel_binary_flowgraph.h View 6 chunks +0 lines, -12 lines 0 comments Download
M runtime/vm/kernel_binary_flowgraph.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M tests/compiler/dart2js_extra/assert_with_message_test.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
A tests/language/arithmetic2_test.dart View 1 1 chunk +73 lines, -0 lines 0 comments Download
A + tests/language/assert_assignable_type_test.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A tests/language/assert_initializer_test.dart View 1 1 chunk +228 lines, -0 lines 0 comments Download
A + tests/language/assert_message_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + tests/language/assert_trailing_comma_test.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language/assert_with_type_test_or_cast_test.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language/assertion_initializer_const_error2_test.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language/assertion_initializer_const_error_test.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language/assertion_initializer_const_function_error_test.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language/assertion_initializer_const_function_test.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language/assertion_initializer_test.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
A tests/language/assertion_test.dart View 1 1 chunk +77 lines, -0 lines 0 comments Download
A + tests/language/assign_instance_method_negative_test.dart View 1 2 chunks +5 lines, -10 lines 0 comments Download
A + tests/language/assign_op_test.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A tests/language/assign_static_type_test.dart View 1 1 chunk +33 lines, -0 lines 0 comments Download
A tests/language/assign_to_type_test.dart View 1 1 chunk +29 lines, -0 lines 0 comments Download
A + tests/language/assign_top_method_test.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
A tests/language/assignable_expression_test.dart View 1 1 chunk +44 lines, -0 lines 0 comments Download
A + tests/language/async_and_or_test.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language/async_await_catch_regression_test.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language/async_await_syntax_test.dart View 1 4 chunks +5 lines, -5 lines 0 comments Download
A + tests/language/async_backwards_compatibility_1_test.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language/async_backwards_compatibility_2_test.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language/async_break_in_finally_test.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language/async_continue_label_test.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language/async_control_structures_test.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language/async_finally_rethrow_test.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language/async_helper_lib.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A tests/language/async_or_generator_return_type_stacktrace_test.dart View 1 1 chunk +35 lines, -0 lines 0 comments Download
A + tests/language/async_regression_23058_test.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language/async_rethrow_test.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language/async_return_types_test.dart View 1 2 chunks +5 lines, -4 lines 0 comments Download
A + tests/language/async_star_cancel_and_throw_in_finally_test.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language/async_star_cancel_while_paused_test.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language/async_star_no_cancel2_test.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language/async_star_no_cancel_test.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language/async_star_pause_test.dart View 1 2 chunks +3 lines, -5 lines 0 comments Download
A + tests/language/async_star_regression_2238_test.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language/async_star_regression_23116_test.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language/async_star_regression_fisk_test.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language/async_star_stream_take_test.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language/async_star_take_reyield_test.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M tests/language/language.status View 1 8 chunks +79 lines, -0 lines 0 comments Download
M tests/language/language_analyzer2.status View 1 1 chunk +5 lines, -0 lines 0 comments Download
M tests/language/language_dart2js.status View 1 11 chunks +185 lines, -0 lines 0 comments Download
M tests/language/language_kernel.status View 1 3 chunks +49 lines, -0 lines 0 comments Download
D tests/language_2/assert_assignable_type_test.dart View 1 1 chunk +0 lines, -28 lines 0 comments Download
D tests/language_2/assert_message_test.dart View 1 1 chunk +0 lines, -105 lines 0 comments Download
D tests/language_2/assert_trailing_comma_test.dart View 1 1 chunk +0 lines, -12 lines 0 comments Download
D tests/language_2/assert_with_message_test.dart View 1 1 chunk +0 lines, -88 lines 0 comments Download
D tests/language_2/assert_with_type_test_or_cast_test.dart View 1 1 chunk +0 lines, -28 lines 0 comments Download
D tests/language_2/assertion_initializer_const_error2_test.dart View 1 1 chunk +0 lines, -64 lines 0 comments Download
D tests/language_2/assertion_initializer_const_error_test.dart View 1 1 chunk +0 lines, -20 lines 0 comments Download
D tests/language_2/assertion_initializer_const_function_error_test.dart View 1 1 chunk +0 lines, -29 lines 0 comments Download
D tests/language_2/assertion_initializer_const_function_test.dart View 1 1 chunk +0 lines, -29 lines 0 comments Download
D tests/language_2/assertion_initializer_test.dart View 1 1 chunk +0 lines, -140 lines 0 comments Download
D tests/language_2/assertion_test.dart View 1 1 chunk +0 lines, -115 lines 0 comments Download
D tests/language_2/assign_instance_method_test.dart View 1 1 chunk +0 lines, -23 lines 0 comments Download
D tests/language_2/assign_op_test.dart View 1 1 chunk +0 lines, -96 lines 0 comments Download
D tests/language_2/assign_static_type_test.dart View 1 1 chunk +0 lines, -25 lines 0 comments Download
D tests/language_2/assign_to_type_test.dart View 1 1 chunk +0 lines, -25 lines 0 comments Download
D tests/language_2/assign_top_method_test.dart View 1 1 chunk +0 lines, -14 lines 0 comments Download
D tests/language_2/assignable_expression_test.dart View 1 1 chunk +0 lines, -44 lines 0 comments Download
D tests/language_2/async_and_or_test.dart View 1 1 chunk +0 lines, -88 lines 0 comments Download
D tests/language_2/async_await_catch_regression_test.dart View 1 1 chunk +0 lines, -26 lines 0 comments Download
D tests/language_2/async_await_foreign_test.dart View 1 1 chunk +0 lines, -72 lines 0 comments Download
D tests/language_2/async_await_syntax_test.dart View 1 1 chunk +0 lines, -301 lines 0 comments Download
D tests/language_2/async_backwards_compatibility_1_test.dart View 1 1 chunk +0 lines, -18 lines 0 comments Download
D tests/language_2/async_backwards_compatibility_2_test.dart View 1 1 chunk +0 lines, -17 lines 0 comments Download
D tests/language_2/async_break_in_finally_test.dart View 1 1 chunk +0 lines, -54 lines 0 comments Download
D tests/language_2/async_call_test.dart View 1 1 chunk +0 lines, -28 lines 0 comments Download
D tests/language_2/async_cascade_test.dart View 1 1 chunk +0 lines, -30 lines 0 comments Download
D tests/language_2/async_continue_label_test.dart View 1 1 chunk +0 lines, -116 lines 0 comments Download
D tests/language_2/async_control_structures_test.dart View 1 1 chunk +0 lines, -97 lines 0 comments Download
D tests/language_2/async_finally_rethrow_test.dart View 1 1 chunk +0 lines, -28 lines 0 comments Download
D tests/language_2/async_helper_lib.dart View 1 1 chunk +0 lines, -7 lines 0 comments Download
D tests/language_2/async_or_generator_return_type_stacktrace_test.dart View 1 1 chunk +0 lines, -11 lines 0 comments Download
D tests/language_2/async_regression_23058_test.dart View 1 1 chunk +0 lines, -36 lines 0 comments Download
D tests/language_2/async_rethrow_test.dart View 1 1 chunk +0 lines, -49 lines 0 comments Download
D tests/language_2/async_return_types_test.dart View 1 1 chunk +0 lines, -72 lines 0 comments Download
D tests/language_2/async_star_await_pauses_test.dart View 1 1 chunk +0 lines, -35 lines 0 comments Download
D tests/language_2/async_star_cancel_and_throw_in_finally_test.dart View 1 1 chunk +0 lines, -42 lines 0 comments Download
D tests/language_2/async_star_cancel_while_paused_test.dart View 1 1 chunk +0 lines, -68 lines 0 comments Download
D tests/language_2/async_star_no_cancel2_test.dart View 1 1 chunk +0 lines, -59 lines 0 comments Download
D tests/language_2/async_star_no_cancel_test.dart View 1 1 chunk +0 lines, -49 lines 0 comments Download
D tests/language_2/async_star_pause_test.dart View 1 1 chunk +0 lines, -46 lines 0 comments Download
D tests/language_2/async_star_regression_2238_test.dart View 1 1 chunk +0 lines, -22 lines 0 comments Download
D tests/language_2/async_star_regression_23116_test.dart View 1 1 chunk +0 lines, -33 lines 0 comments Download
D tests/language_2/async_star_regression_fisk_test.dart View 1 1 chunk +0 lines, -59 lines 0 comments Download
D tests/language_2/async_star_stream_take_test.dart View 1 1 chunk +0 lines, -25 lines 0 comments Download
D tests/language_2/async_star_take_reyield_test.dart View 1 1 chunk +0 lines, -28 lines 0 comments Download
M tests/language_2/language_2.status View 1 2 chunks +1 line, -438 lines 0 comments Download
A tests/language_strong/arithmetic2_test.dart View 1 1 chunk +73 lines, -0 lines 0 comments Download
A + tests/language_strong/assert_assignable_type_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
A + tests/language_strong/assert_with_message_test.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_strong/assert_with_type_test_or_cast_test.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_strong/assertion_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + tests/language_strong/assign_instance_method_negative_test.dart View 1 2 chunks +5 lines, -10 lines 0 comments Download
A + tests/language_strong/assign_op_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
A tests/language_strong/assign_static_type_test.dart View 1 1 chunk +33 lines, -0 lines 0 comments Download
A tests/language_strong/assign_to_type_test.dart View 1 1 chunk +29 lines, -0 lines 0 comments Download
A + tests/language_strong/assign_top_method_test.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
A tests/language_strong/assignable_expression_test.dart View 1 1 chunk +44 lines, -0 lines 0 comments Download
A + tests/language_strong/async_and_or_test.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_strong/async_await_catch_regression_test.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_strong/async_await_foreign_test.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_strong/async_await_syntax_test.dart View 1 4 chunks +5 lines, -5 lines 0 comments Download
A + tests/language_strong/async_backwards_compatibility_1_test.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_strong/async_backwards_compatibility_2_test.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_strong/async_break_in_finally_test.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_strong/async_call_test.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_strong/async_cascade_test.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_strong/async_continue_label_test.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_strong/async_control_structures_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
A + tests/language_strong/async_finally_rethrow_test.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_strong/async_helper_lib.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A tests/language_strong/async_or_generator_return_type_stacktrace_test.dart View 1 1 chunk +35 lines, -0 lines 0 comments Download
A + tests/language_strong/async_regression_23058_test.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_strong/async_rethrow_test.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_strong/async_return_types_test.dart View 1 3 chunks +5 lines, -22 lines 0 comments Download
A + tests/language_strong/async_star_await_pauses_test.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_strong/async_star_cancel_and_throw_in_finally_test.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_strong/async_star_cancel_while_paused_test.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_strong/async_star_regression_2238_test.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_strong/async_star_regression_23116_test.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_strong/async_star_regression_fisk_test.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_strong/async_star_stream_take_test.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_strong/async_star_take_reyield_test.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M tests/language_strong/language_strong.status View 1 1 chunk +9 lines, -0 lines 0 comments Download
M tests/language_strong/language_strong_kernel.status View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
erikcorry
3 years, 4 months ago (2017-07-28 09:59:19 UTC) #1
karlklose
LGTM
3 years, 4 months ago (2017-07-28 10:23:39 UTC) #2
Johnni Winther
lgtm
3 years, 4 months ago (2017-07-28 12:05:40 UTC) #7
erikcorry
3 years, 4 months ago (2017-07-28 12:08:30 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
e431e93e872d9a1c97a5177ebb09d5416f1d659a.

Powered by Google App Engine
This is Rietveld 408576698