Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1592)

Unified Diff: pkg/kernel/lib/binary/ast_to_binary.dart

Issue 2986093002: Revert two Kernel changes that were causing test failures. (Closed)
Patch Set: Revert "Migrate language/async_backwards... ... language/async_star_take..." Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/kernel/lib/binary/ast_from_binary.dart ('k') | pkg/kernel/lib/verifier.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/kernel/lib/binary/ast_to_binary.dart
diff --git a/pkg/kernel/lib/binary/ast_to_binary.dart b/pkg/kernel/lib/binary/ast_to_binary.dart
index 8af490ff2e30d17a3211e6a635707fbacdbaaf97..0462336e05b0bd3a806cfd3a163f2c494ce6672b 100644
--- a/pkg/kernel/lib/binary/ast_to_binary.dart
+++ b/pkg/kernel/lib/binary/ast_to_binary.dart
@@ -344,19 +344,14 @@ class BinaryPrinter extends Visitor {
}
void visitTypedef(Typedef node) {
- _variableIndexer = new VariableIndexer();
writeCanonicalNameReference(getCanonicalNameOfTypedef(node));
writeOffset(node.fileOffset);
writeStringReference(node.name);
writeUriReference(node.fileUri ?? '');
_typeParameterIndexer.enter(node.typeParameters);
writeNodeList(node.typeParameters);
- writeUInt30(node.requiredParameterCount);
- writeVariableDeclarationList(node.positionalParameters);
- writeVariableDeclarationList(node.namedParameters);
writeNode(node.type);
_typeParameterIndexer.exit(node.typeParameters);
- _variableIndexer = null;
}
void writeAnnotation(Expression annotation) {
@@ -420,7 +415,6 @@ class BinaryPrinter extends Visitor {
Class parent = node.parent;
writeUInt30(parent.binaryOffset);
writeName(node.name ?? _emptyName);
- writeStringReference(node.documentationComment ?? '');
writeAnnotationList(node.annotations);
assert(node.function.typeParameters.isEmpty);
writeNode(node.function);
@@ -450,7 +444,6 @@ class BinaryPrinter extends Visitor {
}
writeName(node.name ?? '');
writeUriReference(node.fileUri ?? '');
- writeStringReference(node.documentationComment ?? '');
writeAnnotationList(node.annotations);
writeOptionalNode(node.function);
_variableIndexer = null;
@@ -474,7 +467,6 @@ class BinaryPrinter extends Visitor {
}
writeName(node.name);
writeUriReference(node.fileUri ?? '');
- writeStringReference(node.documentationComment ?? '');
writeAnnotationList(node.annotations);
writeNode(node.type);
writeOptionalNode(node.initializer);
@@ -1378,29 +1370,11 @@ class StringIndexer extends RecursiveVisitor<Null> {
node.visitChildren(this);
}
- @override
- visitConstructor(Constructor node) {
- putOptional(node.documentationComment);
- super.visitConstructor(node);
- }
-
- @override
- visitField(Field node) {
- putOptional(node.documentationComment);
- super.visitField(node);
- }
-
visitNamedExpression(NamedExpression node) {
put(node.name);
node.visitChildren(this);
}
- @override
- visitProcedure(Procedure node) {
- putOptional(node.documentationComment);
- super.visitProcedure(node);
- }
-
visitStringLiteral(StringLiteral node) {
put(node.value);
}
« no previous file with comments | « pkg/kernel/lib/binary/ast_from_binary.dart ('k') | pkg/kernel/lib/verifier.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698