Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2985173002: Migrate language/async_backwards... ... language/async_star_take... (Closed)

Created:
3 years, 4 months ago by Bob Nystrom
Modified:
3 years, 4 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Migrate language/async_backwards... ... language/async_star_take... R=bkonyi@google.com Committed: https://github.com/dart-lang/sdk/commit/557cab2a3e2ffa1cc12b9f7b00b1463c30b2f61d

Patch Set 1 #

Patch Set 2 : Update tests to Dart 2.0. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -1853 lines) Patch
D tests/language/async_backwards_compatibility_2_test.dart View 1 chunk +0 lines, -17 lines 0 comments Download
D tests/language/async_break_in_finally_test.dart View 1 chunk +0 lines, -54 lines 0 comments Download
D tests/language/async_continue_label_test.dart View 1 chunk +0 lines, -116 lines 0 comments Download
D tests/language/async_control_structures_test.dart View 1 chunk +0 lines, -97 lines 0 comments Download
D tests/language/async_finally_rethrow_test.dart View 1 chunk +0 lines, -28 lines 0 comments Download
D tests/language/async_helper_lib.dart View 1 chunk +0 lines, -7 lines 0 comments Download
D tests/language/async_or_generator_return_type_stacktrace_test.dart View 1 chunk +0 lines, -35 lines 0 comments Download
D tests/language/async_regression_23058_test.dart View 1 chunk +0 lines, -36 lines 0 comments Download
D tests/language/async_rethrow_test.dart View 1 chunk +0 lines, -49 lines 0 comments Download
D tests/language/async_return_types_test.dart View 1 chunk +0 lines, -73 lines 0 comments Download
D tests/language/async_star_cancel_and_throw_in_finally_test.dart View 1 chunk +0 lines, -42 lines 0 comments Download
D tests/language/async_star_cancel_while_paused_test.dart View 1 chunk +0 lines, -68 lines 0 comments Download
D tests/language/async_star_no_cancel2_test.dart View 1 chunk +0 lines, -59 lines 0 comments Download
D tests/language/async_star_no_cancel_test.dart View 1 chunk +0 lines, -49 lines 0 comments Download
D tests/language/async_star_pause_test.dart View 1 chunk +0 lines, -44 lines 0 comments Download
D tests/language/async_star_regression_2238_test.dart View 1 chunk +0 lines, -22 lines 0 comments Download
D tests/language/async_star_regression_23116_test.dart View 1 chunk +0 lines, -33 lines 0 comments Download
D tests/language/async_star_regression_fisk_test.dart View 1 chunk +0 lines, -59 lines 0 comments Download
D tests/language/async_star_stream_take_test.dart View 1 chunk +0 lines, -25 lines 0 comments Download
D tests/language/async_star_take_reyield_test.dart View 1 chunk +0 lines, -28 lines 0 comments Download
M tests/language/language.status View 1 4 chunks +0 lines, -14 lines 0 comments Download
M tests/language/language_dart2js.status View 1 5 chunks +0 lines, -39 lines 0 comments Download
M tests/language/language_kernel.status View 1 1 chunk +0 lines, -2 lines 0 comments Download
A + tests/language_2/async_backwards_compatibility_2_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/async_break_in_finally_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/async_call_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/async_cascade_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/async_continue_label_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/async_control_structures_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/async_finally_rethrow_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/async_helper_lib.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A tests/language_2/async_or_generator_return_type_stacktrace_test.dart View 1 1 chunk +11 lines, -0 lines 0 comments Download
A + tests/language_2/async_regression_23058_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/async_rethrow_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/async_return_types_test.dart View 1 2 chunks +4 lines, -5 lines 0 comments Download
A + tests/language_2/async_star_await_pauses_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/async_star_cancel_and_throw_in_finally_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/async_star_cancel_while_paused_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/async_star_no_cancel2_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/async_star_no_cancel_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/async_star_pause_test.dart View 1 2 chunks +5 lines, -3 lines 0 comments Download
A + tests/language_2/async_star_regression_2238_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/async_star_regression_23116_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/async_star_regression_fisk_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/async_star_stream_take_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/async_star_take_reyield_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
M tests/language_2/language_2.status View 1 2 chunks +94 lines, -0 lines 0 comments Download
D tests/language_strong/async_backwards_compatibility_2_test.dart View 1 chunk +0 lines, -17 lines 0 comments Download
D tests/language_strong/async_break_in_finally_test.dart View 1 chunk +0 lines, -54 lines 0 comments Download
D tests/language_strong/async_call_test.dart View 1 chunk +0 lines, -28 lines 0 comments Download
D tests/language_strong/async_cascade_test.dart View 1 chunk +0 lines, -30 lines 0 comments Download
D tests/language_strong/async_continue_label_test.dart View 1 chunk +0 lines, -116 lines 0 comments Download
D tests/language_strong/async_control_structures_test.dart View 1 chunk +0 lines, -97 lines 0 comments Download
D tests/language_strong/async_finally_rethrow_test.dart View 1 chunk +0 lines, -28 lines 0 comments Download
D tests/language_strong/async_helper_lib.dart View 1 chunk +0 lines, -7 lines 0 comments Download
D tests/language_strong/async_or_generator_return_type_stacktrace_test.dart View 1 chunk +0 lines, -35 lines 0 comments Download
D tests/language_strong/async_regression_23058_test.dart View 1 chunk +0 lines, -36 lines 0 comments Download
D tests/language_strong/async_rethrow_test.dart View 1 chunk +0 lines, -49 lines 0 comments Download
D tests/language_strong/async_return_types_test.dart View 1 chunk +0 lines, -55 lines 0 comments Download
D tests/language_strong/async_star_await_pauses_test.dart View 1 chunk +0 lines, -35 lines 0 comments Download
D tests/language_strong/async_star_cancel_and_throw_in_finally_test.dart View 1 chunk +0 lines, -42 lines 0 comments Download
D tests/language_strong/async_star_cancel_while_paused_test.dart View 1 chunk +0 lines, -68 lines 0 comments Download
D tests/language_strong/async_star_regression_2238_test.dart View 1 chunk +0 lines, -22 lines 0 comments Download
D tests/language_strong/async_star_regression_23116_test.dart View 1 chunk +0 lines, -33 lines 0 comments Download
D tests/language_strong/async_star_regression_fisk_test.dart View 1 chunk +0 lines, -59 lines 0 comments Download
D tests/language_strong/async_star_stream_take_test.dart View 1 chunk +0 lines, -25 lines 0 comments Download
D tests/language_strong/async_star_take_reyield_test.dart View 1 chunk +0 lines, -28 lines 0 comments Download
M tests/language_strong/language_strong_kernel.status View 1 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Bob Nystrom
3 years, 4 months ago (2017-07-27 01:10:14 UTC) #2
bkonyi
LGTM
3 years, 4 months ago (2017-07-27 19:08:47 UTC) #3
bkonyi
LGTM
3 years, 4 months ago (2017-07-27 19:08:47 UTC) #4
Bob Nystrom
3 years, 4 months ago (2017-07-27 22:48:35 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
557cab2a3e2ffa1cc12b9f7b00b1463c30b2f61d.

Powered by Google App Engine
This is Rietveld 408576698