Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2990873002: Add Member.documentationComment and use it to resynthesize documentation from Kernel. (Closed)

Created:
3 years, 4 months ago by scheglov
Modified:
3 years, 4 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add Member.documentationComment and use it to resynthesize documentation from Kernel. R=ahe@google.com, brianwilkerson@google.com, sigmund@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/47ecf72272c6153759758791bb880a4a51ee49a8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -64 lines) Patch
M pkg/analyzer/lib/src/dart/element/element.dart View 2 chunks +6 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_kernel_test.dart View 7 chunks +0 lines, -35 lines 0 comments Download
M pkg/front_end/lib/src/fasta/builder/field_builder.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/front_end/lib/src/fasta/builder/member_builder.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/builder/procedure_builder.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/dill/dill_member_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_enum_builder.dart View 3 chunks +24 lines, -6 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_field_builder.dart View 3 chunks +4 lines, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart View 7 chunks +16 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_procedure_builder.dart View 8 chunks +29 lines, -6 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_target.dart View 1 chunk +13 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/outline_builder.dart View 5 chunks +12 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/source_library_builder.dart View 4 chunks +7 lines, -4 lines 0 comments Download
M pkg/kernel/lib/ast.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/kernel/lib/binary/ast_from_binary.dart View 6 chunks +6 lines, -0 lines 0 comments Download
M pkg/kernel/lib/binary/ast_to_binary.dart View 4 chunks +21 lines, -0 lines 0 comments Download
M runtime/vm/kernel_binary_flowgraph.h View 6 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
3 years, 4 months ago (2017-07-27 18:16:28 UTC) #1
Brian Wilkerson
lgtm
3 years, 4 months ago (2017-07-27 18:50:14 UTC) #2
Siggi Cherem (dart-lang)
lgtm
3 years, 4 months ago (2017-07-27 21:52:58 UTC) #3
scheglov
3 years, 4 months ago (2017-07-27 22:22:56 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
47ecf72272c6153759758791bb880a4a51ee49a8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698