Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(1649)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Unified Diff: tests/language/assign_op_test.dart
Issue
2986093002
:
Revert two Kernel changes that were causing test failures. (Closed)
Patch Set: Revert "Migrate language/async_backwards... ... language/async_star_take..."
Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Jump to:
pkg/analyzer/lib/src/dart/element/element.dart
pkg/analyzer/test/src/summary/resynthesize_common.dart
pkg/analyzer/test/src/summary/resynthesize_kernel_test.dart
pkg/front_end/lib/src/fasta/builder/field_builder.dart
pkg/front_end/lib/src/fasta/builder/member_builder.dart
pkg/front_end/lib/src/fasta/builder/procedure_builder.dart
pkg/front_end/lib/src/fasta/dill/dill_member_builder.dart
pkg/front_end/lib/src/fasta/kernel/kernel_enum_builder.dart
pkg/front_end/lib/src/fasta/kernel/kernel_field_builder.dart
pkg/front_end/lib/src/fasta/kernel/kernel_function_type_alias_builder.dart
pkg/front_end/lib/src/fasta/kernel/kernel_function_type_builder.dart
pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart
pkg/front_end/lib/src/fasta/kernel/kernel_procedure_builder.dart
pkg/front_end/lib/src/fasta/kernel/kernel_target.dart
pkg/front_end/lib/src/fasta/source/outline_builder.dart
pkg/front_end/lib/src/fasta/source/source_library_builder.dart
pkg/kernel/lib/ast.dart
pkg/kernel/lib/binary/ast_from_binary.dart
pkg/kernel/lib/binary/ast_to_binary.dart
pkg/kernel/lib/verifier.dart
runtime/vm/kernel_binary_flowgraph.h
runtime/vm/kernel_binary_flowgraph.cc
tests/compiler/dart2js_extra/assert_with_message_test.dart
tests/language/arithmetic2_test.dart
tests/language/assert_assignable_type_test.dart
tests/language/assert_initializer_test.dart
tests/language/assert_message_test.dart
tests/language/assert_trailing_comma_test.dart
tests/language/assert_with_type_test_or_cast_test.dart
tests/language/assertion_initializer_const_error2_test.dart
tests/language/assertion_initializer_const_error_test.dart
tests/language/assertion_initializer_const_function_error_test.dart
tests/language/assertion_initializer_const_function_test.dart
tests/language/assertion_initializer_test.dart
tests/language/assertion_test.dart
tests/language/assign_instance_method_negative_test.dart
tests/language/assign_op_test.dart
tests/language/assign_static_type_test.dart
tests/language/assign_to_type_test.dart
tests/language/assign_top_method_test.dart
tests/language/assignable_expression_test.dart
tests/language/async_and_or_test.dart
tests/language/async_await_catch_regression_test.dart
tests/language/async_await_syntax_test.dart
tests/language/async_backwards_compatibility_1_test.dart
tests/language/async_backwards_compatibility_2_test.dart
tests/language/async_break_in_finally_test.dart
tests/language/async_continue_label_test.dart
tests/language/async_control_structures_test.dart
tests/language/async_finally_rethrow_test.dart
tests/language/async_helper_lib.dart
tests/language/async_or_generator_return_type_stacktrace_test.dart
tests/language/async_regression_23058_test.dart
tests/language/async_rethrow_test.dart
tests/language/async_return_types_test.dart
tests/language/async_star_cancel_and_throw_in_finally_test.dart
tests/language/async_star_cancel_while_paused_test.dart
tests/language/async_star_no_cancel2_test.dart
tests/language/async_star_no_cancel_test.dart
tests/language/async_star_pause_test.dart
tests/language/async_star_regression_2238_test.dart
tests/language/async_star_regression_23116_test.dart
tests/language/async_star_regression_fisk_test.dart
tests/language/async_star_stream_take_test.dart
tests/language/async_star_take_reyield_test.dart
tests/language/language.status
tests/language/language_analyzer2.status
tests/language/language_dart2js.status
tests/language/language_kernel.status
tests/language_2/assert_assignable_type_test.dart
tests/language_2/assert_message_test.dart
tests/language_2/assert_trailing_comma_test.dart
tests/language_2/assert_with_message_test.dart
tests/language_2/assert_with_type_test_or_cast_test.dart
tests/language_2/assertion_initializer_const_error2_test.dart
tests/language_2/assertion_initializer_const_error_test.dart
tests/language_2/assertion_initializer_const_function_error_test.dart
tests/language_2/assertion_initializer_const_function_test.dart
tests/language_2/assertion_initializer_test.dart
tests/language_2/assertion_test.dart
tests/language_2/assign_instance_method_test.dart
tests/language_2/assign_op_test.dart
tests/language_2/assign_static_type_test.dart
tests/language_2/assign_to_type_test.dart
tests/language_2/assign_top_method_test.dart
tests/language_2/assignable_expression_test.dart
tests/language_2/async_and_or_test.dart
tests/language_2/async_await_catch_regression_test.dart
tests/language_2/async_await_foreign_test.dart
tests/language_2/async_await_syntax_test.dart
tests/language_2/async_backwards_compatibility_1_test.dart
tests/language_2/async_backwards_compatibility_2_test.dart
tests/language_2/async_break_in_finally_test.dart
tests/language_2/async_call_test.dart
tests/language_2/async_cascade_test.dart
tests/language_2/async_continue_label_test.dart
tests/language_2/async_control_structures_test.dart
tests/language_2/async_finally_rethrow_test.dart
tests/language_2/async_helper_lib.dart
tests/language_2/async_or_generator_return_type_stacktrace_test.dart
tests/language_2/async_regression_23058_test.dart
tests/language_2/async_rethrow_test.dart
tests/language_2/async_return_types_test.dart
tests/language_2/async_star_await_pauses_test.dart
tests/language_2/async_star_cancel_and_throw_in_finally_test.dart
tests/language_2/async_star_cancel_while_paused_test.dart
tests/language_2/async_star_no_cancel2_test.dart
tests/language_2/async_star_no_cancel_test.dart
tests/language_2/async_star_pause_test.dart
tests/language_2/async_star_regression_2238_test.dart
tests/language_2/async_star_regression_23116_test.dart
tests/language_2/async_star_regression_fisk_test.dart
tests/language_2/async_star_stream_take_test.dart
tests/language_2/async_star_take_reyield_test.dart
tests/language_2/language_2.status
tests/language_strong/arithmetic2_test.dart
tests/language_strong/assert_assignable_type_test.dart
tests/language_strong/assert_with_message_test.dart
tests/language_strong/assert_with_type_test_or_cast_test.dart
tests/language_strong/assertion_test.dart
tests/language_strong/assign_instance_method_negative_test.dart
tests/language_strong/assign_op_test.dart
tests/language_strong/assign_static_type_test.dart
tests/language_strong/assign_to_type_test.dart
tests/language_strong/assign_top_method_test.dart
tests/language_strong/assignable_expression_test.dart
tests/language_strong/async_and_or_test.dart
tests/language_strong/async_await_catch_regression_test.dart
tests/language_strong/async_await_foreign_test.dart
tests/language_strong/async_await_syntax_test.dart
tests/language_strong/async_backwards_compatibility_1_test.dart
tests/language_strong/async_backwards_compatibility_2_test.dart
tests/language_strong/async_break_in_finally_test.dart
tests/language_strong/async_call_test.dart
tests/language_strong/async_cascade_test.dart
tests/language_strong/async_continue_label_test.dart
tests/language_strong/async_control_structures_test.dart
tests/language_strong/async_finally_rethrow_test.dart
tests/language_strong/async_helper_lib.dart
tests/language_strong/async_or_generator_return_type_stacktrace_test.dart
tests/language_strong/async_regression_23058_test.dart
tests/language_strong/async_rethrow_test.dart
tests/language_strong/async_return_types_test.dart
tests/language_strong/async_star_await_pauses_test.dart
tests/language_strong/async_star_cancel_and_throw_in_finally_test.dart
tests/language_strong/async_star_cancel_while_paused_test.dart
tests/language_strong/async_star_regression_2238_test.dart
tests/language_strong/async_star_regression_23116_test.dart
tests/language_strong/async_star_regression_fisk_test.dart
tests/language_strong/async_star_stream_take_test.dart
tests/language_strong/async_star_take_reyield_test.dart
tests/language_strong/language_strong.status
tests/language_strong/language_strong_kernel.status
View side-by-side diff with in-line comments
Download patch
« no previous file with comments
|
« tests/language/assign_instance_method_negative_test.dart
('k') |
tests/language/assign_static_type_test.dart »
('j') |
no next file with comments »
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
Index: tests/language/assign_op_test.dart
diff --git a/tests/language_2/assign_op_test.dart b/tests/language/assign_op_test.dart
similarity index 100%
copy from tests/language_2/assign_op_test.dart
copy to tests/language/assign_op_test.dart
« no previous file with comments
|
« tests/language/assign_instance_method_negative_test.dart
('k') |
tests/language/assign_static_type_test.dart »
('j') |
no next file with comments »
Issue 2986093002: Revert two Kernel changes that were causing test failures. (Closed)
Created 3 years, 5 months ago by erikcorry
Modified 3 years, 5 months ago
Reviewers: karlklose, Johnni Winther
Base URL:
Comments: 0
This is Rietveld
408576698