Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: pkg/front_end/lib/src/fasta/kernel/kernel_field_builder.dart

Issue 2986093002: Revert two Kernel changes that were causing test failures. (Closed)
Patch Set: Revert "Migrate language/async_backwards... ... language/async_star_take..." Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/kernel/kernel_field_builder.dart
diff --git a/pkg/front_end/lib/src/fasta/kernel/kernel_field_builder.dart b/pkg/front_end/lib/src/fasta/kernel/kernel_field_builder.dart
index d4d7a8712d04ac2a9889168a794ee2dc63453501..cecbe48ba31c440e44e6b55ed4401ad363aba541 100644
--- a/pkg/front_end/lib/src/fasta/kernel/kernel_field_builder.dart
+++ b/pkg/front_end/lib/src/fasta/kernel/kernel_field_builder.dart
@@ -37,7 +37,6 @@ class KernelFieldBuilder extends FieldBuilder<Expression> {
final bool hasInitializer;
KernelFieldBuilder(
- String documentationComment,
this.metadata,
this.type,
String name,
@@ -48,8 +47,7 @@ class KernelFieldBuilder extends FieldBuilder<Expression> {
this.hasInitializer)
: field = new KernelField(null, fileUri: compilationUnit?.relativeFileUri)
..fileOffset = charOffset,
- super(
- documentationComment, name, modifiers, compilationUnit, charOffset);
+ super(name, modifiers, compilationUnit, charOffset);
void set initializer(Expression value) {
if (!hasInitializer && value is! NullLiteral && !isConst && !isFinal) {
@@ -63,7 +61,6 @@ class KernelFieldBuilder extends FieldBuilder<Expression> {
type == null && (hasInitializer || isInstanceMember);
Field build(SourceLibraryBuilder library) {
- field.documentationComment = documentationComment;
field.name ??= new Name(name, library.target);
if (type != null) {
field.type = type.build(library);

Powered by Google App Engine
This is Rietveld 408576698