Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2990773002: Migrate language/arithmetic2_test ... language/async_await_syntax_test. (Closed)

Created:
3 years, 4 months ago by Bob Nystrom
Modified:
3 years, 4 months ago
Reviewers:
erikcorry, bkonyi, sra1
CC:
reviews_dartlang.org, dart2now-team_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Migrate language/arithmetic2_test ... language/async_await_syntax_test. R=sra@google.com Committed: https://github.com/dart-lang/sdk/commit/23952fdf56bd83e4ae098b7307fd494b74efa71e

Patch Set 1 #

Patch Set 2 : Update migrated tests and statuses to Dart 2.0. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+422 lines, -2825 lines) Patch
M tests/compiler/dart2js_extra/assert_with_message_test.dart View 1 1 chunk +0 lines, -1 line 0 comments Download
D tests/language/arithmetic2_test.dart View 1 chunk +0 lines, -73 lines 0 comments Download
D tests/language/assert_assignable_type_test.dart View 1 1 chunk +0 lines, -28 lines 0 comments Download
D tests/language/assert_initializer_test.dart View 1 chunk +0 lines, -228 lines 0 comments Download
D tests/language/assert_message_test.dart View 1 chunk +0 lines, -105 lines 0 comments Download
D tests/language/assert_trailing_comma_test.dart View 1 chunk +0 lines, -12 lines 0 comments Download
D tests/language/assert_with_type_test_or_cast_test.dart View 1 chunk +0 lines, -28 lines 0 comments Download
D tests/language/assertion_initializer_const_error2_test.dart View 1 chunk +0 lines, -64 lines 0 comments Download
D tests/language/assertion_initializer_const_error_test.dart View 1 chunk +0 lines, -20 lines 0 comments Download
D tests/language/assertion_initializer_const_function_error_test.dart View 1 chunk +0 lines, -29 lines 0 comments Download
D tests/language/assertion_initializer_const_function_test.dart View 1 chunk +0 lines, -29 lines 0 comments Download
D tests/language/assertion_initializer_test.dart View 1 chunk +0 lines, -140 lines 0 comments Download
D tests/language/assertion_test.dart View 1 1 chunk +0 lines, -77 lines 0 comments Download
D tests/language/assign_instance_method_negative_test.dart View 1 chunk +0 lines, -18 lines 0 comments Download
D tests/language/assign_op_test.dart View 1 1 chunk +0 lines, -96 lines 0 comments Download
D tests/language/assign_static_type_test.dart View 1 chunk +0 lines, -33 lines 0 comments Download
D tests/language/assign_to_type_test.dart View 1 chunk +0 lines, -29 lines 0 comments Download
D tests/language/assign_top_method_test.dart View 1 1 chunk +0 lines, -15 lines 0 comments Download
D tests/language/assignable_expression_test.dart View 1 chunk +0 lines, -44 lines 0 comments Download
D tests/language/async_and_or_test.dart View 1 chunk +0 lines, -88 lines 0 comments Download
D tests/language/async_await_catch_regression_test.dart View 1 chunk +0 lines, -26 lines 0 comments Download
D tests/language/async_await_syntax_test.dart View 1 chunk +0 lines, -301 lines 0 comments Download
M tests/language/language.status View 1 5 chunks +0 lines, -71 lines 0 comments Download
M tests/language/language_analyzer2.status View 1 1 chunk +0 lines, -5 lines 0 comments Download
M tests/language/language_dart2js.status View 1 8 chunks +0 lines, -146 lines 0 comments Download
M tests/language/language_kernel.status View 1 3 chunks +0 lines, -47 lines 0 comments Download
A + tests/language_2/assert_assignable_type_test.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/assert_message_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + tests/language_2/assert_trailing_comma_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/assert_with_message_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/assert_with_type_test_or_cast_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/assertion_initializer_const_error2_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/assertion_initializer_const_error_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/assertion_initializer_const_function_error_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/assertion_initializer_const_function_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/assertion_initializer_test.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + tests/language_2/assertion_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + tests/language_2/assign_instance_method_test.dart View 1 2 chunks +10 lines, -5 lines 0 comments Download
A + tests/language_2/assign_op_test.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A tests/language_2/assign_static_type_test.dart View 1 1 chunk +25 lines, -0 lines 0 comments Download
A tests/language_2/assign_to_type_test.dart View 1 1 chunk +25 lines, -0 lines 0 comments Download
A + tests/language_2/assign_top_method_test.dart View 1 1 chunk +1 line, -2 lines 0 comments Download
A tests/language_2/assignable_expression_test.dart View 1 1 chunk +44 lines, -0 lines 0 comments Download
A + tests/language_2/async_and_or_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/async_await_catch_regression_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/async_await_foreign_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/async_await_syntax_test.dart View 1 4 chunks +5 lines, -5 lines 0 comments Download
M tests/language_2/language_2.status View 1 2 chunks +317 lines, -0 lines 0 comments Download
D tests/language_strong/arithmetic2_test.dart View 1 chunk +0 lines, -73 lines 0 comments Download
D tests/language_strong/assert_assignable_type_test.dart View 1 chunk +0 lines, -28 lines 0 comments Download
D tests/language_strong/assert_with_message_test.dart View 1 chunk +0 lines, -88 lines 0 comments Download
D tests/language_strong/assert_with_type_test_or_cast_test.dart View 1 chunk +0 lines, -28 lines 0 comments Download
D tests/language_strong/assertion_test.dart View 1 chunk +0 lines, -115 lines 0 comments Download
D tests/language_strong/assign_instance_method_negative_test.dart View 1 chunk +0 lines, -18 lines 0 comments Download
D tests/language_strong/assign_op_test.dart View 1 chunk +0 lines, -96 lines 0 comments Download
D tests/language_strong/assign_static_type_test.dart View 1 chunk +0 lines, -33 lines 0 comments Download
D tests/language_strong/assign_to_type_test.dart View 1 chunk +0 lines, -29 lines 0 comments Download
D tests/language_strong/assign_top_method_test.dart View 1 chunk +0 lines, -15 lines 0 comments Download
D tests/language_strong/assignable_expression_test.dart View 1 chunk +0 lines, -44 lines 0 comments Download
D tests/language_strong/async_and_or_test.dart View 1 chunk +0 lines, -88 lines 0 comments Download
D tests/language_strong/async_await_catch_regression_test.dart View 1 chunk +0 lines, -26 lines 0 comments Download
D tests/language_strong/async_await_foreign_test.dart View 1 chunk +0 lines, -72 lines 0 comments Download
D tests/language_strong/async_await_syntax_test.dart View 1 chunk +0 lines, -301 lines 0 comments Download
M tests/language_strong/language_strong.status View 1 1 chunk +0 lines, -9 lines 0 comments Download
M tests/language_strong/language_strong_kernel.status View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Bob Nystrom
This one was rougher than usual since there is a bunch of new assert-related functionality ...
3 years, 4 months ago (2017-07-26 22:15:54 UTC) #2
sra1
lgtm
3 years, 4 months ago (2017-07-26 23:00:14 UTC) #3
Bob Nystrom
Committed patchset #2 (id:20001) manually as 23952fdf56bd83e4ae098b7307fd494b74efa71e.
3 years, 4 months ago (2017-07-27 23:13:54 UTC) #5
erikcorry
This caused some redness, hopefully fixed in https://codereview.chromium.org/2984363003
3 years, 4 months ago (2017-07-28 09:29:29 UTC) #7
erikcorry
3 years, 4 months ago (2017-07-28 11:55:30 UTC) #8
Message was sent while issue was closed. 
On 2017/07/28 09:29:29, erikcorry wrote:
> This caused some redness, hopefully fixed in
> https://codereview.chromium.org/2984363003

Ended up reverting along with several other changes from yesterday in an attempt
to get back to a green bot: https://codereview.chromium.org/2986093002/

Powered by Google App Engine
This is Rietveld 408576698