Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Unified Diff: tests/language_2/async_star_no_cancel2_test.dart

Issue 2986093002: Revert two Kernel changes that were causing test failures. (Closed)
Patch Set: Revert "Migrate language/async_backwards... ... language/async_star_take..." Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/language_2/async_star_no_cancel2_test.dart
diff --git a/tests/language_2/async_star_no_cancel2_test.dart b/tests/language_2/async_star_no_cancel2_test.dart
deleted file mode 100644
index d98b1585c0f6e98d5f4a6b5abad3faa8999ffa62..0000000000000000000000000000000000000000
--- a/tests/language_2/async_star_no_cancel2_test.dart
+++ /dev/null
@@ -1,59 +0,0 @@
-// Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
-// for details. All rights reserved. Use of this source code is governed by a
-// BSD-style license that can be found in the LICENSE file.
-
-import "dart:async";
-import "package:expect/expect.dart";
-import "package:async_helper/async_helper.dart";
-
-var events = [];
-
-var timer;
-ticker(period) async* {
- var sc;
- sc = new StreamController(onListen: () {
- events.add("listen");
- timer = new Timer.periodic(period, (_) {
- sc.add(null);
- });
- }, onCancel: () {
- events.add("cancel");
- timer.cancel();
- });
-
- try {
- var counter = 0;
- await for (var tick in sc.stream) {
- counter++;
- }
- } finally {
- events.add("finally");
- }
-}
-
-void main() {
- asyncStart();
- events.add("main");
- final subscription =
- ticker(const Duration(milliseconds: 20)).listen((val) {});
-
- bool cancelFinished = false;
- new Timer(const Duration(milliseconds: 100), () async {
- // Despite the cancel call below, the stream doesn't stop.
- // The async* function is not blocked at any await (since the inner timer
- // continuously ticks), but since there/ is no yield-point in the function
- // it won't cancel.
- new Timer(const Duration(milliseconds: 30), () {
- Expect.isFalse(cancelFinished);
- Expect.listEquals(["main", "listen", "invoke cancel"], events);
- timer.cancel();
- asyncEnd();
- });
-
- events.add("invoke cancel");
- await subscription.cancel();
- // This line should never be reached, since the cancel-future doesn't
- // complete.
- cancelFinished = true;
- });
-}
« no previous file with comments | « tests/language_2/async_star_cancel_while_paused_test.dart ('k') | tests/language_2/async_star_no_cancel_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698