Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Unified Diff: pkg/kernel/lib/binary/ast_from_binary.dart

Issue 2986093002: Revert two Kernel changes that were causing test failures. (Closed)
Patch Set: Revert "Migrate language/async_backwards... ... language/async_star_take..." Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/kernel/lib/ast.dart ('k') | pkg/kernel/lib/binary/ast_to_binary.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/kernel/lib/binary/ast_from_binary.dart
diff --git a/pkg/kernel/lib/binary/ast_from_binary.dart b/pkg/kernel/lib/binary/ast_from_binary.dart
index 346ebf53b93464fc458c07af0a7f9816336f5d35..47e398ae763ae172caf1ee6fc1e5e8fb225e2b81 100644
--- a/pkg/kernel/lib/binary/ast_from_binary.dart
+++ b/pkg/kernel/lib/binary/ast_from_binary.dart
@@ -438,13 +438,6 @@ class BinaryBuilder {
String name = readStringReference();
String fileUri = readUriReference();
readAndPushTypeParameterList(node.typeParameters, node);
-
- int requiredParameterCount = readUInt();
- var positionalParameters = readVariableDeclarationList();
- var namedParameters = readVariableDeclarationList();
- node.setParameters(
- requiredParameterCount, positionalParameters, namedParameters);
-
var type = readDartType();
typeParameterStack.length = 0;
if (shouldWriteData) {
@@ -532,7 +525,6 @@ class BinaryBuilder {
readUInt(); // parent class binary offset.
var name = readName();
var fileUri = readUriReference();
- var documentationComment = readStringOrNullIfEmpty();
var annotations = readAnnotationList(node);
debugPath.add(node.name?.name ?? 'field');
var type = readDartType();
@@ -545,7 +537,6 @@ class BinaryBuilder {
node.flags = flags;
node.name = name;
node.fileUri = fileUri;
- node.documentationComment = documentationComment;
node.annotations = annotations;
node.type = type;
node.initializer = initializer;
@@ -570,7 +561,6 @@ class BinaryBuilder {
var flags = readByte();
readUInt(); // parent class binary offset.
var name = readName();
- var documentationComment = readStringOrNullIfEmpty();
var annotations = readAnnotationList(node);
debugPath.add(node.name?.name ?? 'constructor');
var function = readFunctionNode();
@@ -589,7 +579,6 @@ class BinaryBuilder {
node.fileEndOffset = fileEndOffset;
node.flags = flags;
node.name = name;
- node.documentationComment = documentationComment;
node.annotations = annotations;
node.function = function..parent = node;
node.transformerFlags = transformerFlags;
@@ -615,7 +604,6 @@ class BinaryBuilder {
readUInt(); // parent class binary offset.
var name = readName();
var fileUri = readUriReference();
- var documentationComment = readStringOrNullIfEmpty();
var annotations = readAnnotationList(node);
debugPath.add(node.name?.name ?? 'procedure');
var function = readFunctionNodeOption();
@@ -628,7 +616,6 @@ class BinaryBuilder {
node.flags = flags;
node.name = name;
node.fileUri = fileUri;
- node.documentationComment = documentationComment;
node.annotations = annotations;
node.function = function;
node.function?.parent = node;
@@ -1234,11 +1221,6 @@ class BinaryBuilder {
return new NamedExpression(readStringReference(), readExpression());
}
- List<VariableDeclaration> readVariableDeclarationList() {
- return new List<VariableDeclaration>.generate(
- readUInt(), (i) => readVariableDeclaration());
- }
-
List<VariableDeclaration> readAndPushVariableDeclarationList() {
return new List<VariableDeclaration>.generate(
readUInt(), (i) => readAndPushVariableDeclaration());
« no previous file with comments | « pkg/kernel/lib/ast.dart ('k') | pkg/kernel/lib/binary/ast_to_binary.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698