Description was changed from ========== Remove asMatrix as a JS-exposed method in CSSTransformComponents. It's still ...
3 years, 6 months ago
(2017-06-09 07:45:51 UTC)
#1
Description was changed from
==========
Remove asMatrix as a JS-exposed method in CSSTransformComponents.
It's still useful for calculating the asMatrix method in
CSSTransformValue, so I kept the method as an internal one, but made it
return a DOMMatrix instead.
BUG=545318
==========
to
==========
Remove asMatrix as a JS-exposed method in CSSTransformComponents.
It has been removed from the spec:
https://drafts.css-houdini.org/css-typed-om/#csstransformcomponent
It's still useful for calculating the asMatrix method in
CSSTransformValue, so I kept the method as an internal one, but made it
return a DOMMatrix instead.
BUG=545318
==========
meade_UTC10
Description was changed from ========== Remove asMatrix as a JS-exposed method in CSSTransformComponents. It has ...
3 years, 6 months ago
(2017-06-09 07:49:04 UTC)
#2
Description was changed from
==========
Remove asMatrix as a JS-exposed method in CSSTransformComponents.
It has been removed from the spec:
https://drafts.css-houdini.org/css-typed-om/#csstransformcomponent
It's still useful for calculating the asMatrix method in
CSSTransformValue, so I kept the method as an internal one, but made it
return a DOMMatrix instead.
BUG=545318
==========
to
==========
Remove asMatrix as a JS-exposed method in CSSTransformComponents.
It has been removed from the spec:
https://drafts.css-houdini.org/css-typed-om/#csstransformcomponent
It's still useful for calculating the asMatrix method in
CSSTransformValue, so I kept the method as an internal one, but made it
return a DOMMatrix instead.
Deleted unnecessary functions, and updated tests.
BUG=545318
==========
meade_UTC10
Patchset #2 (id:20001) has been deleted
3 years, 6 months ago
(2017-06-09 07:49:35 UTC)
#3
Patchset #2 (id:20001) has been deleted
meade_UTC10
Patchset #4 (id:80001) has been deleted
3 years, 6 months ago
(2017-06-09 07:49:45 UTC)
#4
Patchset #4 (id:80001) has been deleted
meade_UTC10
Patchset #3 (id:60001) has been deleted
3 years, 6 months ago
(2017-06-09 07:49:54 UTC)
#5
Patchset #3 (id:60001) has been deleted
meade_UTC10
Patchset #3 (id:100001) has been deleted
3 years, 6 months ago
(2017-06-09 07:50:11 UTC)
#6
Patchset #3 (id:100001) has been deleted
meade_UTC10
Patchset #2 (id:40001) has been deleted
3 years, 6 months ago
(2017-06-09 07:50:33 UTC)
#7
Patchset #2 (id:40001) has been deleted
meade_UTC10
Patchset #2 (id:120001) has been deleted
3 years, 6 months ago
(2017-06-09 07:52:47 UTC)
#8
Patchset #2 (id:120001) has been deleted
meade_UTC10
Patchset #2 (id:140001) has been deleted
3 years, 6 months ago
(2017-06-09 07:53:58 UTC)
#9
Hi Renee, PTAL. I tried to keep this change as simple as possible, and have ...
3 years, 6 months ago
(2017-06-09 07:54:56 UTC)
#11
Hi Renee,
PTAL. I tried to keep this change as simple as possible, and have moved all the
documentation changes we discussed to a new CL.
Cheers,
E
rjwright
On 2017/06/09 07:54:56, meade_UTC10 wrote: > Hi Renee, > > PTAL. I tried to keep ...
3 years, 6 months ago
(2017-06-14 05:40:01 UTC)
#12
On 2017/06/09 07:54:56, meade_UTC10 wrote:
> Hi Renee,
>
> PTAL. I tried to keep this change as simple as possible, and have moved all
the
> documentation changes we discussed to a new CL.
>
> Cheers,
> E
LGTM
meade_UTC10
The CQ bit was checked by meade@chromium.org
3 years, 6 months ago
(2017-06-14 07:29:21 UTC)
#13
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/231555) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 6 months ago
(2017-06-14 07:31:56 UTC)
#16
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/469545)
3 years, 6 months ago
(2017-06-16 09:59:52 UTC)
#36
CQ is committing da patch. Bot data: {"patchset_id": 360001, "attempt_start_ts": 1497858404186510, "parent_rev": "c9071b89d53629922166599c013a70c83a26ce2e", "commit_rev": "4b74fa1307784d2fe83c3dad453874e7b3911331"}
3 years, 6 months ago
(2017-06-19 09:41:42 UTC)
#40
CQ is committing da patch.
Bot data: {"patchset_id": 360001, "attempt_start_ts": 1497858404186510,
"parent_rev": "c9071b89d53629922166599c013a70c83a26ce2e", "commit_rev":
"4b74fa1307784d2fe83c3dad453874e7b3911331"}
commit-bot: I haz the power
Description was changed from ========== Remove asMatrix as a JS-exposed method in CSSTransformComponents. It has ...
3 years, 6 months ago
(2017-06-19 09:42:12 UTC)
#41
Message was sent while issue was closed.
Description was changed from
==========
Remove asMatrix as a JS-exposed method in CSSTransformComponents.
It has been removed from the spec:
https://drafts.css-houdini.org/css-typed-om/#csstransformcomponent
It's still useful for calculating the asMatrix method in
CSSTransformValue, so I kept the method as an internal one, but made it
return a DOMMatrix instead.
Deleted unnecessary functions, and updated tests.
BUG=545318
==========
to
==========
Remove asMatrix as a JS-exposed method in CSSTransformComponents.
It has been removed from the spec:
https://drafts.css-houdini.org/css-typed-om/#csstransformcomponent
It's still useful for calculating the asMatrix method in
CSSTransformValue, so I kept the method as an internal one, but made it
return a DOMMatrix instead.
Deleted unnecessary functions, and updated tests.
BUG=545318
Review-Url: https://codereview.chromium.org/2933473003
Cr-Commit-Position: refs/heads/master@{#480384}
Committed:
https://chromium.googlesource.com/chromium/src/+/4b74fa1307784d2fe83c3dad4538...
==========
commit-bot: I haz the power
Committed patchset #13 (id:360001) as https://chromium.googlesource.com/chromium/src/+/4b74fa1307784d2fe83c3dad453874e7b3911331
3 years, 6 months ago
(2017-06-19 09:42:13 UTC)
#42
Issue 2933473003: Remove asMatrix as a JS-exposed method in CSSTransformComponents.
(Closed)
Created 3 years, 6 months ago by meade_UTC10
Modified 3 years, 6 months ago
Reviewers: nainar, rjwright
Base URL:
Comments: 0