Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 2933473003: Remove asMatrix as a JS-exposed method in CSSTransformComponents. (Closed)

Created:
3 years, 6 months ago by meade_UTC10
Modified:
3 years, 6 months ago
Reviewers:
nainar, rjwright
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove asMatrix as a JS-exposed method in CSSTransformComponents. It has been removed from the spec: https://drafts.css-houdini.org/css-typed-om/#csstransformcomponent It's still useful for calculating the asMatrix method in CSSTransformValue, so I kept the method as an internal one, but made it return a DOMMatrix instead. Deleted unnecessary functions, and updated tests. BUG=545318 Review-Url: https://codereview.chromium.org/2933473003 Cr-Commit-Position: refs/heads/master@{#480384} Committed: https://chromium.googlesource.com/chromium/src/+/4b74fa1307784d2fe83c3dad453874e7b3911331

Patch Set 1 #

Patch Set 2 : Update tests #

Patch Set 3 : rebase #

Patch Set 4 : Undo some spurious changes #

Patch Set 5 : Don't delete cssSkew tests #

Patch Set 6 : Reparent branch #

Patch Set 7 : move some changes to parent branch #

Patch Set 8 : Revert spurious changes #

Patch Set 9 : rebase #

Patch Set 10 : Update cssSkew test #

Patch Set 11 : rebase #

Patch Set 12 : Add interface expectations #

Patch Set 13 : update skew expectation for missing "s" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -174 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/worklet/webexposed/global-interface-listing-paint-worklet-expected.txt View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/cssMatrixComponent.html View 1 2 3 4 5 1 chunk +0 lines, -14 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/cssScale.html View 1 2 3 4 5 6 7 8 9 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/cssSkew.html View 1 2 3 4 5 6 7 8 9 10 11 3 chunks +11 lines, -16 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/cssSkew-expected.txt View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-expected.txt View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSMatrixComponent.h View 3 chunks +1 line, -23 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSMatrixComponent.cpp View 2 chunks +0 lines, -81 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSPerspective.h View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSRotation.h View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSScale.h View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSSkew.h View 1 2 3 4 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSSkew.cpp View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSTransformComponent.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSTransformComponent.idl View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSTransformValue.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSTranslation.h View 2 chunks +3 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 42 (29 generated)
meade_UTC10
Hi Renee, PTAL. I tried to keep this change as simple as possible, and have ...
3 years, 6 months ago (2017-06-09 07:54:56 UTC) #11
rjwright
On 2017/06/09 07:54:56, meade_UTC10 wrote: > Hi Renee, > > PTAL. I tried to keep ...
3 years, 6 months ago (2017-06-14 05:40:01 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2933473003/160001
3 years, 6 months ago (2017-06-14 07:29:38 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/231555) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 6 months ago (2017-06-14 07:31:56 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2933473003/180001
3 years, 6 months ago (2017-06-14 07:34:53 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2933473003/200001
3 years, 6 months ago (2017-06-14 08:01:09 UTC) #23
meade_UTC10
On 2017/06/14 08:01:09, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
3 years, 6 months ago (2017-06-14 09:10:24 UTC) #26
meade_UTC10
3 years, 6 months ago (2017-06-16 07:29:50 UTC) #30
nainar
lgtm outside of tests. Didn't look at that
3 years, 6 months ago (2017-06-16 07:40:39 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2933473003/340001
3 years, 6 months ago (2017-06-16 07:49:12 UTC) #34
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/469545)
3 years, 6 months ago (2017-06-16 09:59:52 UTC) #36
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2933473003/360001
3 years, 6 months ago (2017-06-19 07:46:53 UTC) #39
commit-bot: I haz the power
3 years, 6 months ago (2017-06-19 09:42:13 UTC) #42
Message was sent while issue was closed.
Committed patchset #13 (id:360001) as
https://chromium.googlesource.com/chromium/src/+/4b74fa1307784d2fe83c3dad4538...

Powered by Google App Engine
This is Rietveld 408576698