Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Side by Side Diff: third_party/WebKit/Source/core/css/cssom/CSSPerspective.h

Issue 2933473003: Remove asMatrix as a JS-exposed method in CSSTransformComponents. (Closed)
Patch Set: update skew expectation for missing "s" Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CSSPerspective_h 5 #ifndef CSSPerspective_h
6 #define CSSPerspective_h 6 #define CSSPerspective_h
7 7
8 #include "core/CoreExport.h" 8 #include "core/CoreExport.h"
9 #include "core/css/cssom/CSSNumericValue.h" 9 #include "core/css/cssom/CSSNumericValue.h"
10 #include "core/css/cssom/CSSTransformComponent.h" 10 #include "core/css/cssom/CSSTransformComponent.h"
11 11
12 namespace blink { 12 namespace blink {
13 13
14 class DOMMatrix;
14 class ExceptionState; 15 class ExceptionState;
15 16
16 class CORE_EXPORT CSSPerspective : public CSSTransformComponent { 17 class CORE_EXPORT CSSPerspective : public CSSTransformComponent {
17 WTF_MAKE_NONCOPYABLE(CSSPerspective); 18 WTF_MAKE_NONCOPYABLE(CSSPerspective);
18 DEFINE_WRAPPERTYPEINFO(); 19 DEFINE_WRAPPERTYPEINFO();
19 20
20 public: 21 public:
21 static CSSPerspective* Create(const CSSNumericValue*, ExceptionState&); 22 static CSSPerspective* Create(const CSSNumericValue*, ExceptionState&);
22 static CSSPerspective* FromCSSValue(const CSSFunctionValue&); 23 static CSSPerspective* FromCSSValue(const CSSFunctionValue&);
23 24
24 // Bindings require a non const return value. 25 // Bindings require a non const return value.
25 CSSNumericValue* length() const { 26 CSSNumericValue* length() const {
26 return const_cast<CSSNumericValue*>(length_.Get()); 27 return const_cast<CSSNumericValue*>(length_.Get());
27 } 28 }
28 29
29 TransformComponentType GetType() const override { return kPerspectiveType; } 30 TransformComponentType GetType() const override { return kPerspectiveType; }
30 31
31 // TODO: Implement asMatrix for CSSPerspective. 32 // TODO: Implement AsMatrix for CSSPerspective.
32 CSSMatrixComponent* asMatrix() const override { return nullptr; } 33 DOMMatrix* AsMatrix() const override { return nullptr; }
33 34
34 CSSFunctionValue* ToCSSValue() const override; 35 CSSFunctionValue* ToCSSValue() const override;
35 36
36 DEFINE_INLINE_VIRTUAL_TRACE() { 37 DEFINE_INLINE_VIRTUAL_TRACE() {
37 visitor->Trace(length_); 38 visitor->Trace(length_);
38 CSSTransformComponent::Trace(visitor); 39 CSSTransformComponent::Trace(visitor);
39 } 40 }
40 41
41 private: 42 private:
42 CSSPerspective(const CSSNumericValue* length) : length_(length) {} 43 CSSPerspective(const CSSNumericValue* length) : length_(length) {}
43 44
44 Member<const CSSNumericValue> length_; 45 Member<const CSSNumericValue> length_;
45 }; 46 };
46 47
47 } // namespace blink 48 } // namespace blink
48 49
49 #endif 50 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698