Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: third_party/WebKit/Source/core/css/cssom/CSSMatrixComponent.h

Issue 2933473003: Remove asMatrix as a JS-exposed method in CSSTransformComponents. (Closed)
Patch Set: update skew expectation for missing "s" Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/cssom/CSSMatrixComponent.h
diff --git a/third_party/WebKit/Source/core/css/cssom/CSSMatrixComponent.h b/third_party/WebKit/Source/core/css/cssom/CSSMatrixComponent.h
index 4e8f35fa76dfe802f26671ecb3e9b3910e734772..cd4f45ff85acbf61caa6d6703e77b6940d66478a 100644
--- a/third_party/WebKit/Source/core/css/cssom/CSSMatrixComponent.h
+++ b/third_party/WebKit/Source/core/css/cssom/CSSMatrixComponent.h
@@ -5,10 +5,8 @@
#ifndef CSSMatrixComponent_h
#define CSSMatrixComponent_h
-#include <memory>
#include "core/css/cssom/CSSTransformComponent.h"
#include "core/geometry/DOMMatrix.h"
-#include "platform/transforms/TransformationMatrix.h"
namespace blink {
@@ -33,29 +31,10 @@ class CORE_EXPORT CSSMatrixComponent final : public CSSTransformComponent {
return is2d_ ? kMatrixType : kMatrix3DType;
}
- // Bindings require a non const return value.
- CSSMatrixComponent* asMatrix() const override {
- return const_cast<CSSMatrixComponent*>(this);
- }
+ DOMMatrix* AsMatrix() const override { return matrix(); }
CSSFunctionValue* ToCSSValue() const override;
- static CSSMatrixComponent* Perspective(double length);
-
- static CSSMatrixComponent* Rotate(double angle);
- static CSSMatrixComponent* Rotate3d(double angle,
- double x,
- double y,
- double z);
-
- static CSSMatrixComponent* Scale(double x, double y);
- static CSSMatrixComponent* Scale3d(double x, double y, double z);
-
- static CSSMatrixComponent* Skew(double x, double y);
-
- static CSSMatrixComponent* Translate(double x, double y);
- static CSSMatrixComponent* Translate3d(double x, double y, double z);
-
DEFINE_INLINE_VIRTUAL_TRACE() {
visitor->Trace(matrix_);
CSSTransformComponent::Trace(visitor);
@@ -63,7 +42,6 @@ class CORE_EXPORT CSSMatrixComponent final : public CSSTransformComponent {
private:
CSSMatrixComponent(DOMMatrixReadOnly*);
- CSSMatrixComponent(DOMMatrixReadOnly*, TransformComponentType);
Member<DOMMatrix> matrix_;
bool is2d_;

Powered by Google App Engine
This is Rietveld 408576698