third_party/WebKit/Source/core/css/cssom/CSSPerspective.h - Issue 2933473003: Remove asMatrix as a JS-exposed method in CSSTransformComponents.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/cssom/CSSPerspective.h

Issue 2933473003: Remove asMatrix as a JS-exposed method in CSSTransformComponents. (Closed)

Patch Set: update skew expectation for missing "s" Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/cssom/CSSPerspective.h

diff --git a/third_party/WebKit/Source/core/css/cssom/CSSPerspective.h b/third_party/WebKit/Source/core/css/cssom/CSSPerspective.h

index eb49ef59c82cd241d9aef0a2d0e2c5a1f9da0f5b..ab30ff0e3fad86ba35127607683b7d57f9b41c1d 100644

--- a/third_party/WebKit/Source/core/css/cssom/CSSPerspective.h

+++ b/third_party/WebKit/Source/core/css/cssom/CSSPerspective.h

@@ -11,6 +11,7 @@

namespace blink {

+class DOMMatrix;

class ExceptionState;

class CORE_EXPORT CSSPerspective : public CSSTransformComponent {

@@ -28,8 +29,8 @@ class CORE_EXPORT CSSPerspective : public CSSTransformComponent {

TransformComponentType GetType() const override { return kPerspectiveType; }

- // TODO: Implement asMatrix for CSSPerspective.

- CSSMatrixComponent* asMatrix() const override { return nullptr; }

+ // TODO: Implement AsMatrix for CSSPerspective.

+ DOMMatrix* AsMatrix() const override { return nullptr; }

CSSFunctionValue* ToCSSValue() const override;