Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 2935413002: [Typed OM] Add comments and consistent structure to all the CSSTransformComponent subclasses (Closed)

Created:
3 years, 6 months ago by meade_UTC10
Modified:
3 years, 6 months ago
Reviewers:
rjwright
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Typed OM] Add comments and consistent structure to all the CSSTransformComponent subclasses BUG=545318 Review-Url: https://codereview.chromium.org/2935413002 Cr-Commit-Position: refs/heads/master@{#480385} Committed: https://chromium.googlesource.com/chromium/src/+/4c46599615d3bb4af1c914bc583b5cf0ee1a08af

Patch Set 1 #

Total comments: 4

Patch Set 2 : Review comments #

Patch Set 3 : rebase #

Messages

Total messages: 17 (12 generated)
meade_UTC10
3 years, 6 months ago (2017-06-16 04:19:29 UTC) #2
rjwright
LGTM https://codereview.chromium.org/2935413002/diff/1/third_party/WebKit/Source/core/css/cssom/CSSRotation.h File third_party/WebKit/Source/core/css/cssom/CSSRotation.h (right): https://codereview.chromium.org/2935413002/diff/1/third_party/WebKit/Source/core/css/cssom/CSSRotation.h#newcode38 third_party/WebKit/Source/core/css/cssom/CSSRotation.h:38: // Bindings require a non const return value. ...
3 years, 6 months ago (2017-06-16 06:13:04 UTC) #3
meade_UTC10
https://codereview.chromium.org/2935413002/diff/1/third_party/WebKit/Source/core/css/cssom/CSSRotation.h File third_party/WebKit/Source/core/css/cssom/CSSRotation.h (right): https://codereview.chromium.org/2935413002/diff/1/third_party/WebKit/Source/core/css/cssom/CSSRotation.h#newcode38 third_party/WebKit/Source/core/css/cssom/CSSRotation.h:38: // Bindings require a non const return value. On ...
3 years, 6 months ago (2017-06-16 06:43:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2935413002/40001
3 years, 6 months ago (2017-06-19 10:04:25 UTC) #14
commit-bot: I haz the power
3 years, 6 months ago (2017-06-19 10:07:41 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/4c46599615d3bb4af1c914bc583b...

Powered by Google App Engine
This is Rietveld 408576698