Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Unified Diff: third_party/WebKit/Source/core/css/cssom/CSSSkew.h

Issue 2933473003: Remove asMatrix as a JS-exposed method in CSSTransformComponents. (Closed)
Patch Set: update skew expectation for missing "s" Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/cssom/CSSSkew.h
diff --git a/third_party/WebKit/Source/core/css/cssom/CSSSkew.h b/third_party/WebKit/Source/core/css/cssom/CSSSkew.h
index 462f6dccd8596b4fda72feee73eceae1b8c0fb21..e55cf42c8b267216cbc0464f9cbe71d68c1e3607 100644
--- a/third_party/WebKit/Source/core/css/cssom/CSSSkew.h
+++ b/third_party/WebKit/Source/core/css/cssom/CSSSkew.h
@@ -5,15 +5,16 @@
#ifndef CSSSkew_h
#define CSSSkew_h
-#include "core/css/cssom/CSSMatrixComponent.h"
#include "core/css/cssom/CSSNumericValue.h"
#include "core/css/cssom/CSSTransformComponent.h"
namespace blink {
+class ExceptionState;
+
// Represents a skew value in a CSSTransformValue used for properties like
// "transform".
-// See CSSSkew.idl for more documentation about this class.
+// See CSSSkew.idl for more information about this class.
class CORE_EXPORT CSSSkew final : public CSSTransformComponent {
WTF_MAKE_NONCOPYABLE(CSSSkew);
DEFINE_WRAPPERTYPEINFO();
@@ -33,15 +34,14 @@ class CORE_EXPORT CSSSkew final : public CSSTransformComponent {
void setAx(CSSNumericValue*, ExceptionState&);
void setAy(CSSNumericValue*, ExceptionState&);
- CSSMatrixComponent* asMatrix() const override {
+ // Internal methods - from CSSTransformComponent.
+ TransformComponentType GetType() const override { return kSkewType; }
+ DOMMatrix* AsMatrix() const override {
return nullptr;
// TODO(meade): Reimplement this once the number/unit types
// are re-implemented.
// return CSSMatrixComponent::Skew(ax_->degrees(), ay_->degrees());
}
-
- // Internal methods - from CSSTransformComponent.
- TransformComponentType GetType() const override { return kSkewType; }
CSSFunctionValue* ToCSSValue() const override;
DEFINE_INLINE_VIRTUAL_TRACE() {
« no previous file with comments | « third_party/WebKit/Source/core/css/cssom/CSSScale.h ('k') | third_party/WebKit/Source/core/css/cssom/CSSSkew.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698