third_party/WebKit/LayoutTests/typedcssom/cssSkew.html - Issue 2933473003: Remove asMatrix as a JS-exposed method in CSSTransformComponents.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/typedcssom/cssSkew.html

Issue 2933473003: Remove asMatrix as a JS-exposed method in CSSTransformComponents. (Closed)

Patch Set: update skew expectation for missing "s" Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/typedcssom/cssScale.html ('k') | third_party/WebKit/LayoutTests/typedcssom/cssSkew-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/typedcssom/cssSkew.html

diff --git a/third_party/WebKit/LayoutTests/typedcssom/cssSkew.html b/third_party/WebKit/LayoutTests/typedcssom/cssSkew.html

index 25ce2514e1a344a079c849fb5ae4457e6185058e..4e9ac49e6434bdc797947dc46425f2d6cbeda02a 100644

--- a/third_party/WebKit/LayoutTests/typedcssom/cssSkew.html

+++ b/third_party/WebKit/LayoutTests/typedcssom/cssSkew.html

@@ -1,6 +1,7 @@

<!DOCTYPE html>

+<script src="resources/comparisons.js"></script>

var EPSILON = 1e-6; // float epsilon

@@ -62,7 +63,7 @@ for (let params of testParams) {

assert_equals(params.input.ax.unit, params.ax.unit);

assert_approx_equals(params.input.ay.value, params.ay.value, EPSILON);

assert_equals(params.input.ay.unit, params.ay.unit);

- }, "(ax, ay) value is correct for " + params.cssText);

+ }, "(ax, ay) values are correct for " + params.cssText);

}

for (let params of testParams) {

@@ -90,24 +91,18 @@ test(() => {

for (let params of testParams) {

test(() => {

var input = params.input;

- var inputAsMatrix = input.asMatrix();

- assert_true(inputAsMatrix.is2D());

- var tanAx = tanUnitValue(input.ax.degrees);

- var tanAy = tanUnitValue(input.ay.degrees);

- var expectedMatrix = new CSSMatrixComponent(

- new DOMMatrixReadOnly([1, tanAy, tanAx, 1, 0, 0]));

- for (var attribute in expectedMatrix) {

- if (attribute == "matrix") {

- assert_matrix_approx_equals(

- inputAsMatrix[attribute], expectedMatrix[attribute], epsilon);

- } else {

- assert_equals(inputAsMatrix[attribute], expectedMatrix[attribute]);

- }

+ var transformValue = new CSSTransformValue([input]);

+ var inputAsMatrix = transformValue.toMatrix();

+ assert_true(inputAsMatrix.is2D);

+ var tanAx = tanUnitValue(input.ax);

+ var tanAy = tanUnitValue(input.ay);

+ var expectedMatrix = new DOMMatrixReadOnly([1, tanAy, tanAx, 1, 0, 0]);

+ assert_matrix_approx_equals(inputAsMatrix, expectedMatrix, EPSILON);

}, "asMatrix is constructed correctly for " + params.cssText);

}

-test(function() {

+test(() => {

var skew = new CSSSkew(

new CSSUnitValue(1, 'deg'), new CSSUnitValue(2, 'deg'));

skew.ax = new CSSUnitValue(3, 'deg');