Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: third_party/WebKit/Source/core/css/cssom/CSSSkew.cpp

Issue 2933473003: Remove asMatrix as a JS-exposed method in CSSTransformComponents. (Closed)
Patch Set: update skew expectation for missing "s" Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/css/cssom/CSSSkew.h" 5 #include "core/css/cssom/CSSSkew.h"
6 6
7 #include "bindings/core/v8/ExceptionState.h"
7 #include "core/css/CSSFunctionValue.h" 8 #include "core/css/CSSFunctionValue.h"
8 #include "core/css/CSSPrimitiveValue.h" 9 #include "core/css/CSSPrimitiveValue.h"
9 #include "core/css/cssom/CSSNumericValue.h" 10 #include "core/css/cssom/CSSNumericValue.h"
10 #include "core/css/cssom/CSSUnitValue.h" 11 #include "core/css/cssom/CSSUnitValue.h"
11 12
12 namespace blink { 13 namespace blink {
13 14
14 void CSSSkew::setAx(CSSNumericValue* value, ExceptionState& exception_state) { 15 void CSSSkew::setAx(CSSNumericValue* value, ExceptionState& exception_state) {
15 if (value->GetType() != CSSStyleValue::StyleValueType::kAngleType) { 16 if (value->GetType() != CSSStyleValue::StyleValueType::kAngleType) {
16 exception_state.ThrowTypeError("Must specify an angle unit"); 17 exception_state.ThrowTypeError("Must specify an angle unit");
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
78 return nullptr; 79 return nullptr;
79 // TODO(meade): Re-implement this when we finish rewriting number/length 80 // TODO(meade): Re-implement this when we finish rewriting number/length
80 // types. 81 // types.
81 // CSSFunctionValue* result = CSSFunctionValue::Create(CSSValueSkew); 82 // CSSFunctionValue* result = CSSFunctionValue::Create(CSSValueSkew);
82 // result->Append(*CSSPrimitiveValue::Create(ax_->Value(), ax_->Unit())); 83 // result->Append(*CSSPrimitiveValue::Create(ax_->Value(), ax_->Unit()));
83 // result->Append(*CSSPrimitiveValue::Create(ay_->Value(), ay_->Unit())); 84 // result->Append(*CSSPrimitiveValue::Create(ay_->Value(), ay_->Unit()));
84 // return result; 85 // return result;
85 } 86 }
86 87
87 } // namespace blink 88 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/css/cssom/CSSSkew.h ('k') | third_party/WebKit/Source/core/css/cssom/CSSTransformComponent.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698