Deprecate NonThreadSafe in components/sync in favor of SequenceChecker.

Deprecate NonThreadSafe in components/sync in favor of SequenceChecker.

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c8.

Note-worthy for the reviewer:
 * SequenceChecker enforces thread-safety but not thread-affinity!
   If the classes that were updated are thread-affine (use thread local
   storage or a third-party API that does) they should be migrated to
   ThreadChecker instead.
 * ~NonThreadSafe() used to implcitly check in its destructor
   ~Sequence/ThreadChecker() doesn't by design. To keep this CL a
   no-op, an explicit check was added to the destructor of migrated
   classes.
 * NonThreadSafe used to provide access to subclasses, as such
   the |sequence_checker_| member was made protected rather than
   private where necessary.

BUG=676387
This CL was uploaded by git cl split.

R=stanisc@chromium.org

Review-Url: https://codereview.chromium.org/2915453002
Cr-Commit-Position: refs/heads/master@{#476015}
Committed: https://chromium.googlesource.com/chromium/src/+/93f8b8a5cc48cc016c1979076b08d16d568c34f1

[gab, 2017-05-29 19:22:15]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[gab, 2017-05-29 19:22:18]

Hi, this is an automated change made by https://crbug.com/676387#c8 and sharded
across directories for OWNERS.

No human has looked at this specific output yet, see cl description for things
to watch for.

If it LGTY, please CQ.

If it didn't pass CQ dry-run it may be a simple patch failure or an IWYU failure
from having this being a partial CL... please review anyways and a human will
look at the failure (and ping for re-review if anything major is required..). It
is known to compile all targets on Windows at r474679...  manual tweaks will
likely be required to smoothen things off, bear with me!

Thanks!
Gab

[commit-bot: I haz the power, 2017-05-29 19:22:25]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-29 20:21:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-29 20:21:17]

Dry run: This issue passed the CQ dry run.

[gab, 2017-05-30 01:26:29]

Description was changed from

==========
Deprecate NonThreadSafe in components/sync in favor of SequenceChecker.

This change was scripted by https://crbug.com/676387#c8.

Note-worthy for the reviewer:
 * SequenceChecker enforces thread-safety but not thread-affinity!
   If the classes that were updated are thread-affine (use thread local
   storage or a third-party API that does) they should be migrated to
   ThreadChecker instead.
 * ~NonThreadSafe() used to implcitly check in its destructor
   ~Sequence/ThreadChecker() doesn't by design. To keep this CL a
   no-op, an explicit check was added to the destructor of migrated
   classes.
 * NonThreadSafe used to provide access to subclasses, as such
   the |sequence_checker_| member was made protected rather than
   private where necessary.

BUG=676387
This CL was uploaded by git cl split.

R=stanisc@chromium.org
==========

to

==========
Deprecate NonThreadSafe in components/sync in favor of SequenceChecker.

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c8.

Note-worthy for the reviewer:
 * SequenceChecker enforces thread-safety but not thread-affinity!
   If the classes that were updated are thread-affine (use thread local
   storage or a third-party API that does) they should be migrated to
   ThreadChecker instead.
 * ~NonThreadSafe() used to implcitly check in its destructor
   ~Sequence/ThreadChecker() doesn't by design. To keep this CL a
   no-op, an explicit check was added to the destructor of migrated
   classes.
 * NonThreadSafe used to provide access to subclasses, as such
   the |sequence_checker_| member was made protected rather than
   private where necessary.

BUG=676387
This CL was uploaded by git cl split.

R=stanisc@chromium.org
==========

[stanisc, 2017-05-30 17:00:08]

Found one minor issue.

https://codereview.chromium.org/2915453002/diff/1/components/sync/base/weak_h...
File components/sync/base/weak_handle.h (right):

https://codereview.chromium.org/2915453002/diff/1/components/sync/base/weak_h...
components/sync/base/weak_handle.h:21: // SEQUENCE_CHECKER(sequence_checker_);
It looks like the script didn't handle this correctly. This comment makes no
sense. Also the next line has an extra //

[gab, 2017-05-31 17:42:23]

PTanL

https://codereview.chromium.org/2915453002/diff/1/components/sync/base/weak_h...
File components/sync/base/weak_handle.h (right):

https://codereview.chromium.org/2915453002/diff/1/components/sync/base/weak_h...
components/sync/base/weak_handle.h:21: // SEQUENCE_CHECKER(sequence_checker_);
On 2017/05/30 17:00:08, stanisc wrote:
> It looks like the script didn't handle this correctly. This comment makes no
> sense. Also the next line has an extra //

Whoops..! Spent a lot of time to make the script handle that... and somehow
messed it up in last version of script which tries to insert above comments to
insertion point (which of course doesn't work for code inside a comment!).

Thankfully this appears to be the only comment with NonThreadSafe in it :) --
guess I should have checked that first before trying hard to handle a use case
for which there was one instance and then failing to do so..!

Fixed.

[gab, 2017-05-31 17:43:30]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-31 17:44:04]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[stanisc, 2017-05-31 18:08:48]

lgtm

[gab, 2017-05-31 18:20:30]

The CQ bit was unchecked by gab@chromium.org

[gab, 2017-05-31 18:20:34]

The CQ bit was checked by gab@chromium.org

[commit-bot: I haz the power, 2017-05-31 18:20:41]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 20:54:20]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496254834155580,
"parent_rev": "5c9c24ec6d1d8ddaae83a9118c5824b6c40f9854", "commit_rev":
"93f8b8a5cc48cc016c1979076b08d16d568c34f1"}

[commit-bot: I haz the power, 2017-05-31 20:54:27]

Description was changed from

==========
Deprecate NonThreadSafe in components/sync in favor of SequenceChecker.

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c8.

Note-worthy for the reviewer:
 * SequenceChecker enforces thread-safety but not thread-affinity!
   If the classes that were updated are thread-affine (use thread local
   storage or a third-party API that does) they should be migrated to
   ThreadChecker instead.
 * ~NonThreadSafe() used to implcitly check in its destructor
   ~Sequence/ThreadChecker() doesn't by design. To keep this CL a
   no-op, an explicit check was added to the destructor of migrated
   classes.
 * NonThreadSafe used to provide access to subclasses, as such
   the |sequence_checker_| member was made protected rather than
   private where necessary.

BUG=676387
This CL was uploaded by git cl split.

R=stanisc@chromium.org
==========

to

==========
Deprecate NonThreadSafe in components/sync in favor of SequenceChecker.

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c8.

Note-worthy for the reviewer:
 * SequenceChecker enforces thread-safety but not thread-affinity!
   If the classes that were updated are thread-affine (use thread local
   storage or a third-party API that does) they should be migrated to
   ThreadChecker instead.
 * ~NonThreadSafe() used to implcitly check in its destructor
   ~Sequence/ThreadChecker() doesn't by design. To keep this CL a
   no-op, an explicit check was added to the destructor of migrated
   classes.
 * NonThreadSafe used to provide access to subclasses, as such
   the |sequence_checker_| member was made protected rather than
   private where necessary.

BUG=676387
This CL was uploaded by git cl split.

R=stanisc@chromium.org

Review-Url: https://codereview.chromium.org/2915453002
Cr-Commit-Position: refs/heads/master@{#476015}
Committed:
https://chromium.googlesource.com/chromium/src/+/93f8b8a5cc48cc016c1979076b08...
==========

[commit-bot: I haz the power, 2017-05-31 20:54:28]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/93f8b8a5cc48cc016c1979076b08...