Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Unified Diff: components/sync/model_impl/attachments/attachment_service_impl.h

Issue 2915453002: Deprecate NonThreadSafe in components/sync in favor of SequenceChecker. (Closed)
Patch Set: fix comment Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync/model_impl/attachments/attachment_service_impl.h
diff --git a/components/sync/model_impl/attachments/attachment_service_impl.h b/components/sync/model_impl/attachments/attachment_service_impl.h
index 1db20e93b4d059a6e5a6444b2fd1e059de8e02e6..251a3104ae7146f03a3423d5dceabbd2cd192412 100644
--- a/components/sync/model_impl/attachments/attachment_service_impl.h
+++ b/components/sync/model_impl/attachments/attachment_service_impl.h
@@ -11,7 +11,7 @@
#include "base/macros.h"
#include "base/memory/ref_counted.h"
#include "base/memory/weak_ptr.h"
-#include "base/threading/non_thread_safe.h"
+#include "base/sequence_checker.h"
#include "components/sync/engine/attachments/attachment_downloader.h"
#include "components/sync/engine/attachments/attachment_uploader.h"
#include "components/sync/model/attachments/attachment_service.h"
@@ -25,8 +25,7 @@ namespace syncer {
// Implementation of AttachmentService.
class AttachmentServiceImpl
: public AttachmentService,
- public net::NetworkChangeNotifier::NetworkChangeObserver,
- public base::NonThreadSafe {
+ public net::NetworkChangeNotifier::NetworkChangeObserver {
public:
// |attachment_store| is required. UploadAttachments reads attachment data
// from it. Downloaded attachments will be written into it.
@@ -110,6 +109,8 @@ class AttachmentServiceImpl
std::unique_ptr<TaskQueue<AttachmentId>> upload_task_queue_;
+ SEQUENCE_CHECKER(sequence_checker_);
+
// Must be last data member.
base::WeakPtrFactory<AttachmentServiceImpl> weak_ptr_factory_;

Powered by Google App Engine
This is Rietveld 408576698