Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: components/sync/base/sync_prefs.h

Issue 2915453002: Deprecate NonThreadSafe in components/sync in favor of SequenceChecker. (Closed)
Patch Set: fix comment Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/sync/base/sync_prefs.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/sync/base/sync_prefs.h
diff --git a/components/sync/base/sync_prefs.h b/components/sync/base/sync_prefs.h
index 4f60110ceecccf09f40d119e1902695b29b43de2..ec36359429c5996188a107945d1d3de9ba33ac07 100644
--- a/components/sync/base/sync_prefs.h
+++ b/components/sync/base/sync_prefs.h
@@ -15,7 +15,7 @@
#include "base/macros.h"
#include "base/memory/weak_ptr.h"
#include "base/observer_list.h"
-#include "base/threading/non_thread_safe.h"
+#include "base/sequence_checker.h"
#include "base/time/time.h"
#include "build/build_config.h"
#include "components/prefs/pref_member.h"
@@ -53,8 +53,7 @@ class SyncPrefObserver {
// sync_setup_wizard.cc
// sync_setup_wizard_unittest.cc
// two_client_preferences_sync_test.cc
-class SyncPrefs : NON_EXPORTED_BASE(public base::NonThreadSafe),
- public base::SupportsWeakPtr<SyncPrefs> {
+class SyncPrefs : public base::SupportsWeakPtr<SyncPrefs> {
public:
// |pref_service| may not be null.
// Does not take ownership of |pref_service|.
@@ -220,6 +219,8 @@ class SyncPrefs : NON_EXPORTED_BASE(public base::NonThreadSafe),
using PrefGroupsMap = std::map<ModelType, ModelTypeSet>;
PrefGroupsMap pref_groups_;
+ SEQUENCE_CHECKER(sequence_checker_);
+
DISALLOW_COPY_AND_ASSIGN(SyncPrefs);
};
« no previous file with comments | « no previous file | components/sync/base/sync_prefs.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698