Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: components/sync/engine_impl/attachments/attachment_uploader_impl.h

Issue 2915453002: Deprecate NonThreadSafe in components/sync in favor of SequenceChecker. (Closed)
Patch Set: fix comment Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync/engine_impl/attachments/attachment_uploader_impl.h
diff --git a/components/sync/engine_impl/attachments/attachment_uploader_impl.h b/components/sync/engine_impl/attachments/attachment_uploader_impl.h
index 90a27800d4ecc5ab0b9afeb69df48d45fb4427c6..3d59d129a40776a0bca556bb22057e183cba7454 100644
--- a/components/sync/engine_impl/attachments/attachment_uploader_impl.h
+++ b/components/sync/engine_impl/attachments/attachment_uploader_impl.h
@@ -12,7 +12,7 @@
#include <unordered_map>
#include "base/macros.h"
-#include "base/threading/non_thread_safe.h"
+#include "base/sequence_checker.h"
#include "components/sync/base/model_type.h"
#include "components/sync/engine/attachments/attachment_uploader.h"
#include "google_apis/gaia/oauth2_token_service_request.h"
@@ -27,8 +27,7 @@ class URLRequestContextGetter;
namespace syncer {
// An implementation of AttachmentUploader.
-class AttachmentUploaderImpl : public AttachmentUploader,
- public base::NonThreadSafe {
+class AttachmentUploaderImpl : public AttachmentUploader {
public:
// |sync_service_url| is the URL of the sync service.
//
@@ -96,6 +95,8 @@ class AttachmentUploaderImpl : public AttachmentUploader,
StateMap state_map_;
ModelType model_type_;
+ SEQUENCE_CHECKER(sequence_checker_);
+
// Must be last data member.
base::WeakPtrFactory<AttachmentUploaderImpl> weak_ptr_factory_;

Powered by Google App Engine
This is Rietveld 408576698