Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: components/sync/engine_impl/js_mutation_event_observer.h

Issue 2915453002: Deprecate NonThreadSafe in components/sync in favor of SequenceChecker. (Closed)
Patch Set: fix comment Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync/engine_impl/js_mutation_event_observer.h
diff --git a/components/sync/engine_impl/js_mutation_event_observer.h b/components/sync/engine_impl/js_mutation_event_observer.h
index ed3d81e5db18a3cb3d139c7d844eb9ed015fe433..09c314ec1736d13f8bf1c447f23641bffe9852e0 100644
--- a/components/sync/engine_impl/js_mutation_event_observer.h
+++ b/components/sync/engine_impl/js_mutation_event_observer.h
@@ -12,7 +12,7 @@
#include "base/compiler_specific.h"
#include "base/macros.h"
#include "base/memory/weak_ptr.h"
-#include "base/threading/non_thread_safe.h"
+#include "base/sequence_checker.h"
#include "components/sync/base/weak_handle.h"
#include "components/sync/engine/sync_manager.h"
#include "components/sync/syncable/transaction_observer.h"
@@ -29,8 +29,7 @@ class JsEventHandler;
// Observes all change- and transaction-related events and routes a
// summarized version to a JsEventHandler.
class JsMutationEventObserver : public SyncManager::ChangeObserver,
- public syncable::TransactionObserver,
- public base::NonThreadSafe {
+ public syncable::TransactionObserver {
public:
JsMutationEventObserver();
@@ -60,6 +59,8 @@ class JsMutationEventObserver : public SyncManager::ChangeObserver,
const std::string& name,
const JsEventDetails& details);
+ SEQUENCE_CHECKER(sequence_checker_);
+
base::WeakPtrFactory<JsMutationEventObserver> weak_ptr_factory_;
DISALLOW_COPY_AND_ASSIGN(JsMutationEventObserver);

Powered by Google App Engine
This is Rietveld 408576698