Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: components/sync/device_info/local_device_info_provider_impl.h

Issue 2915453002: Deprecate NonThreadSafe in components/sync in favor of SequenceChecker. (Closed)
Patch Set: fix comment Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/sync/base/weak_handle.h ('k') | components/sync/device_info/local_device_info_provider_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/sync/device_info/local_device_info_provider_impl.h
diff --git a/components/sync/device_info/local_device_info_provider_impl.h b/components/sync/device_info/local_device_info_provider_impl.h
index a786975ce04ca8c84381e6a03ee2cab726162162..f15743f64265ea21eb11b9c508f5bb9f6ed3c8a7 100644
--- a/components/sync/device_info/local_device_info_provider_impl.h
+++ b/components/sync/device_info/local_device_info_provider_impl.h
@@ -10,15 +10,14 @@
#include "base/macros.h"
#include "base/memory/weak_ptr.h"
-#include "base/threading/non_thread_safe.h"
+#include "base/sequence_checker.h"
#include "components/sync/device_info/device_info.h"
#include "components/sync/device_info/local_device_info_provider.h"
#include "components/version_info/version_info.h"
namespace syncer {
-class LocalDeviceInfoProviderImpl : public LocalDeviceInfoProvider,
- public base::NonThreadSafe {
+class LocalDeviceInfoProviderImpl : public LocalDeviceInfoProvider {
public:
LocalDeviceInfoProviderImpl(version_info::Channel channel,
const std::string& version,
@@ -55,6 +54,9 @@ class LocalDeviceInfoProviderImpl : public LocalDeviceInfoProvider,
std::string cache_guid_;
std::unique_ptr<DeviceInfo> local_device_info_;
base::CallbackList<void(void)> callback_list_;
+
+ SEQUENCE_CHECKER(sequence_checker_);
+
base::WeakPtrFactory<LocalDeviceInfoProviderImpl> weak_factory_;
DISALLOW_COPY_AND_ASSIGN(LocalDeviceInfoProviderImpl);
« no previous file with comments | « components/sync/base/weak_handle.h ('k') | components/sync/device_info/local_device_info_provider_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698