Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: components/sync/base/weak_handle.h

Issue 2915453002: Deprecate NonThreadSafe in components/sync in favor of SequenceChecker. (Closed)
Patch Set: fix comment Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/sync/base/sync_prefs.cc ('k') | components/sync/device_info/local_device_info_provider_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/sync/base/weak_handle.h
diff --git a/components/sync/base/weak_handle.h b/components/sync/base/weak_handle.h
index 5db9810c7b4fa5b4edcdf80c3fa163bfd2cf21a7..dd5915f2aa3ad88b491814c3693eb9ab53cefffb 100644
--- a/components/sync/base/weak_handle.h
+++ b/components/sync/base/weak_handle.h
@@ -47,7 +47,7 @@
// const WeakHandle<Foo> foo_;
// };
//
-// class Foo : public SupportsWeakPtr<Foo>, public NonThreadSafe {
+// class Foo : public SupportsWeakPtr<Foo> {
// public:
// Foo() {
// SpawnFooIOWorkerOnIOThread(base::MakeWeakHandle(AsWeakPtr()));
@@ -58,6 +58,9 @@
// void OnIOStart() { DCHECK(CalledOnValidThread(); ... }
// void OnIOEvent(IOEvent e) { DCHECK(CalledOnValidThread(); ... }
// void OnIOError(IOError err) { DCHECK(CalledOnValidThread(); ... }
+//
+// private:
+// SEQUENCE_CHECKER(sequence_checker_);
// };
namespace tracked_objects {
« no previous file with comments | « components/sync/base/sync_prefs.cc ('k') | components/sync/device_info/local_device_info_provider_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698