Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: components/sync/model_impl/shared_model_type_processor.h

Issue 2915453002: Deprecate NonThreadSafe in components/sync in favor of SequenceChecker. (Closed)
Patch Set: fix comment Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync/model_impl/shared_model_type_processor.h
diff --git a/components/sync/model_impl/shared_model_type_processor.h b/components/sync/model_impl/shared_model_type_processor.h
index 62c136fa5b786369807c7c85b6f2ad9f4d8626fc..d8b54483b8e008cff802ac04bc926c12144941b7 100644
--- a/components/sync/model_impl/shared_model_type_processor.h
+++ b/components/sync/model_impl/shared_model_type_processor.h
@@ -12,7 +12,7 @@
#include "base/memory/weak_ptr.h"
#include "base/optional.h"
-#include "base/threading/non_thread_safe.h"
+#include "base/sequence_checker.h"
#include "components/sync/base/model_type.h"
#include "components/sync/engine/cycle/status_counters.h"
#include "components/sync/engine/model_type_processor.h"
@@ -36,8 +36,7 @@ class ProcessorEntityTracker;
// model type threads. See //docs/sync/uss/shared_model_type_processor.md for a
// more thorough description.
class SharedModelTypeProcessor : public ModelTypeProcessor,
- public ModelTypeChangeProcessor,
- base::NonThreadSafe {
+ public ModelTypeChangeProcessor {
public:
SharedModelTypeProcessor(ModelType type,
ModelTypeSyncBridge* bridge,
@@ -211,6 +210,8 @@ class SharedModelTypeProcessor : public ModelTypeProcessor,
// client tag hash. The other direction can use |entities_|.
std::map<std::string, std::string> storage_key_to_tag_hash_;
+ SEQUENCE_CHECKER(sequence_checker_);
+
// WeakPtrFactory for this processor which will be sent to sync thread.
base::WeakPtrFactory<SharedModelTypeProcessor> weak_ptr_factory_;
« no previous file with comments | « components/sync/model_impl/model_type_store_impl.cc ('k') | components/sync/model_impl/shared_model_type_processor.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698