Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2911123003: Metrics for feature engagement tracker. (Closed)

Created:
3 years, 6 months ago by xingliu
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

Metrics for feature engagement tracker. This CL adds metrics for feature engagement tracker. There are some user actions which are not const char literal, this is probably not ok, so we probably can't use suffixes for user actions. Bug: 726155 Change-Id: Ieb0ca4cf5c49b9f2cd6d7eed5f6afe9fea4faa20 Reviewed-on: https://chromium-review.googlesource.com/514331 Commit-Queue: Xing Liu <xingliu@chromium.org>; Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>; Reviewed-by: Tommy Nyquist <nyquist@chromium.org>; Reviewed-by: David Trainor <dtrainor@chromium.org>; Cr-Original-Commit-Position: refs/heads/master@{#475691} Review-Url: https://codereview.chromium.org/2911123003 . Cr-Commit-Position: refs/branch-heads/3112@{#43} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/b36844f6112ee001d289dda31a858122b23c3852

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+770 lines, -34 lines) Patch
M components/feature_engagement_tracker/internal/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M components/feature_engagement_tracker/internal/availability_store.cc View 4 chunks +5 lines, -0 lines 0 comments Download
M components/feature_engagement_tracker/internal/chrome_variations_configuration.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/feature_engagement_tracker/internal/chrome_variations_configuration.cc View 8 chunks +44 lines, -3 lines 0 comments Download
M components/feature_engagement_tracker/internal/chrome_variations_configuration_unittest.cc View 12 chunks +81 lines, -0 lines 0 comments Download
M components/feature_engagement_tracker/internal/condition_validator.h View 2 chunks +3 lines, -3 lines 0 comments Download
M components/feature_engagement_tracker/internal/condition_validator.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M components/feature_engagement_tracker/internal/condition_validator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/feature_engagement_tracker/internal/configuration.h View 1 chunk +3 lines, -0 lines 0 comments Download
M components/feature_engagement_tracker/internal/editable_configuration.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/feature_engagement_tracker/internal/editable_configuration.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M components/feature_engagement_tracker/internal/feature_config_condition_validator.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/feature_engagement_tracker/internal/feature_config_condition_validator_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/feature_engagement_tracker/internal/feature_engagement_tracker_impl.cc View 4 chunks +10 lines, -11 lines 0 comments Download
M components/feature_engagement_tracker/internal/feature_engagement_tracker_impl_unittest.cc View 3 chunks +16 lines, -0 lines 0 comments Download
M components/feature_engagement_tracker/internal/model_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/feature_engagement_tracker/internal/once_condition_validator.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/feature_engagement_tracker/internal/once_condition_validator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/feature_engagement_tracker/internal/persistent_store.cc View 5 chunks +8 lines, -3 lines 0 comments Download
M components/feature_engagement_tracker/internal/persistent_store_unittest.cc View 7 chunks +36 lines, -1 line 0 comments Download
M components/feature_engagement_tracker/internal/single_invalid_configuration.h View 2 chunks +5 lines, -1 line 0 comments Download
M components/feature_engagement_tracker/internal/single_invalid_configuration.cc View 1 chunk +5 lines, -0 lines 0 comments Download
A components/feature_engagement_tracker/internal/stats.h View 1 chunk +150 lines, -0 lines 0 comments Download
A components/feature_engagement_tracker/internal/stats.cc View 1 chunk +192 lines, -0 lines 0 comments Download
M tools/metrics/actions/actions.xml View 1 chunk +75 lines, -0 lines 0 comments Download
M tools/metrics/histograms/enums.xml View 2 chunks +29 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +88 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
xingliu
3 years, 6 months ago (2017-05-31 00:08:36 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b36844f6112ee001d289dda31a858122b23c3852.

Powered by Google App Engine
This is Rietveld 408576698