components/feature_engagement_tracker/internal/feature_config_condition_validator_unittest.cc - Issue 2911123003: Metrics for feature engagement tracker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/feature_engagement_tracker/internal/feature_config_condition_validator_unittest.cc

Issue 2911123003: Metrics for feature engagement tracker. (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/feature_engagement_tracker/internal/feature_config_condition_validator.cc ('k') | components/feature_engagement_tracker/internal/feature_engagement_tracker_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/feature_engagement_tracker/internal/feature_config_condition_validator_unittest.cc

diff --git a/components/feature_engagement_tracker/internal/feature_config_condition_validator_unittest.cc b/components/feature_engagement_tracker/internal/feature_config_condition_validator_unittest.cc

index b7d30874d89907e1b39f55e496009a0c1d55f650..3853f39f5b9e650c8d8e11aa2425a6dfd4ca51e9 100644

--- a/components/feature_engagement_tracker/internal/feature_config_condition_validator_unittest.cc

+++ b/components/feature_engagement_tracker/internal/feature_config_condition_validator_unittest.cc

@@ -150,7 +150,7 @@ TEST_F(FeatureConfigConditionValidatorTest, ModelNotReadyShouldFail) {

ConditionValidator::Result result =

GetResultForDayZero(GetValidFeatureConfig());

EXPECT_FALSE(result.NoErrors());

- EXPECT_FALSE(result.model_ready_ok);

+ EXPECT_FALSE(result.event_model_ready_ok);

}

TEST_F(FeatureConfigConditionValidatorTest, ConfigInvalidShouldFail) {

@@ -170,7 +170,7 @@ TEST_F(FeatureConfigConditionValidatorTest, MultipleErrorsShouldBeSet) {

ConditionValidator::Result result = GetResultForDayZero(FeatureConfig());

EXPECT_FALSE(result.NoErrors());

- EXPECT_FALSE(result.model_ready_ok);

+ EXPECT_FALSE(result.event_model_ready_ok);

EXPECT_FALSE(result.config_ok);

}