components/feature_engagement_tracker/internal/condition_validator_unittest.cc - Issue 2911123003: Metrics for feature engagement tracker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/feature_engagement_tracker/internal/condition_validator_unittest.cc

Issue 2911123003: Metrics for feature engagement tracker. (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/feature_engagement_tracker/internal/condition_validator.cc ('k') | components/feature_engagement_tracker/internal/configuration.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/feature_engagement_tracker/internal/condition_validator_unittest.cc

diff --git a/components/feature_engagement_tracker/internal/condition_validator_unittest.cc b/components/feature_engagement_tracker/internal/condition_validator_unittest.cc

index 24c7cfa8d359f9c61dfd4d599ea735b34cfe4ecf..a6f8cb599949c6b40576341333cd8ecf237e0ba7 100644

--- a/components/feature_engagement_tracker/internal/condition_validator_unittest.cc

+++ b/components/feature_engagement_tracker/internal/condition_validator_unittest.cc

@@ -18,7 +18,7 @@ TEST(ConditionValidatorResultTest, TestAllErrors) {

TEST(ConditionValidatorResultTest, TestModelNotReady) {

ConditionValidator::Result result(true);

- result.model_ready_ok = false;

+ result.event_model_ready_ok = false;

EXPECT_FALSE(result.NoErrors());

}