Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Unified Diff: components/feature_engagement_tracker/internal/single_invalid_configuration.h

Issue 2911123003: Metrics for feature engagement tracker. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/feature_engagement_tracker/internal/single_invalid_configuration.h
diff --git a/components/feature_engagement_tracker/internal/single_invalid_configuration.h b/components/feature_engagement_tracker/internal/single_invalid_configuration.h
index 449cee97bbe83e0a56152a38ea50229e0761b677..dd0ea1ff7d9bb353f0628d01a759cb9dc883a8e7 100644
--- a/components/feature_engagement_tracker/internal/single_invalid_configuration.h
+++ b/components/feature_engagement_tracker/internal/single_invalid_configuration.h
@@ -17,7 +17,7 @@ struct Feature;
namespace feature_engagement_tracker {
// An Configuration that always returns the same single invalid configuration,
-// regardless of which feature.
+// regardless of which feature. Also holds an empty ConfigMap.
class SingleInvalidConfiguration : public Configuration {
public:
SingleInvalidConfiguration();
@@ -26,11 +26,15 @@ class SingleInvalidConfiguration : public Configuration {
// Configuration implementation.
const FeatureConfig& GetFeatureConfig(
const base::Feature& feature) const override;
+ const Configuration::ConfigMap& GetRegisteredFeatures() const override;
private:
// The invalid configuration to always return.
FeatureConfig invalid_feature_config_;
+ // An empty map.
+ ConfigMap configs_;
+
DISALLOW_COPY_AND_ASSIGN(SingleInvalidConfiguration);
};

Powered by Google App Engine
This is Rietveld 408576698