components/feature_engagement_tracker/internal/model_impl.cc - Issue 2911123003: Metrics for feature engagement tracker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/feature_engagement_tracker/internal/model_impl.cc

Issue 2911123003: Metrics for feature engagement tracker. (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/feature_engagement_tracker/internal/model_impl.cc

diff --git a/components/feature_engagement_tracker/internal/model_impl.cc b/components/feature_engagement_tracker/internal/model_impl.cc

index beced53d3f3fd894f408c2e90e4ac1bb87e39ff5..d1032f52a0c5559242b518c13d02230f22ab8aae 100644

--- a/components/feature_engagement_tracker/internal/model_impl.cc

+++ b/components/feature_engagement_tracker/internal/model_impl.cc

@@ -50,7 +50,6 @@ const Event* ModelImpl::GetEvent(const std::string& event_name) const {

void ModelImpl::IncrementEvent(const std::string& event_name,

uint32_t current_day) {

- // TODO(nyquist): Track this event in UMA.

DCHECK(ready_);

if (!storage_validator_->ShouldStore(event_name))