Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Unified Diff: components/feature_engagement_tracker/internal/condition_validator.cc

Issue 2911123003: Metrics for feature engagement tracker. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/feature_engagement_tracker/internal/condition_validator.cc
diff --git a/components/feature_engagement_tracker/internal/condition_validator.cc b/components/feature_engagement_tracker/internal/condition_validator.cc
index da41166276193bd9c2e6325d0575f3e025a49647..90113483c7475667789cb817e7c216e1fade8ef1 100644
--- a/components/feature_engagement_tracker/internal/condition_validator.cc
+++ b/components/feature_engagement_tracker/internal/condition_validator.cc
@@ -7,7 +7,7 @@
namespace feature_engagement_tracker {
ConditionValidator::Result::Result(bool initial_values)
- : model_ready_ok(initial_values),
+ : event_model_ready_ok(initial_values),
currently_showing_ok(initial_values),
feature_enabled_ok(initial_values),
config_ok(initial_values),
@@ -19,7 +19,7 @@ ConditionValidator::Result::Result(bool initial_values)
availability_ok(initial_values) {}
ConditionValidator::Result::Result(const Result& other) {
- model_ready_ok = other.model_ready_ok;
+ event_model_ready_ok = other.event_model_ready_ok;
currently_showing_ok = other.currently_showing_ok;
feature_enabled_ok = other.feature_enabled_ok;
config_ok = other.config_ok;
@@ -31,8 +31,8 @@ ConditionValidator::Result::Result(const Result& other) {
availability_ok = other.availability_ok;
}
-bool ConditionValidator::Result::NoErrors() {
- return model_ready_ok && currently_showing_ok && feature_enabled_ok &&
+bool ConditionValidator::Result::NoErrors() const {
+ return event_model_ready_ok && currently_showing_ok && feature_enabled_ok &&
config_ok && used_ok && trigger_ok && preconditions_ok &&
session_rate_ok && availability_model_ready_ok && availability_ok;
}

Powered by Google App Engine
This is Rietveld 408576698