components/feature_engagement_tracker/internal/feature_config_condition_validator.cc - Issue 2911123003: Metrics for feature engagement tracker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/feature_engagement_tracker/internal/feature_config_condition_validator.cc

Issue 2911123003: Metrics for feature engagement tracker. (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/feature_engagement_tracker/internal/editable_configuration.cc ('k') | components/feature_engagement_tracker/internal/feature_config_condition_validator_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/feature_engagement_tracker/internal/feature_config_condition_validator.cc

diff --git a/components/feature_engagement_tracker/internal/feature_config_condition_validator.cc b/components/feature_engagement_tracker/internal/feature_config_condition_validator.cc

index fa8ce2a174ec12a73e4e042220bdfeda8e5e316a..ff6e1ad5ef11b33970289d2d762d988f48a9966e 100644

--- a/components/feature_engagement_tracker/internal/feature_config_condition_validator.cc

+++ b/components/feature_engagement_tracker/internal/feature_config_condition_validator.cc

@@ -25,7 +25,7 @@ ConditionValidator::Result FeatureConfigConditionValidator::MeetsConditions(

const AvailabilityModel& availability_model,

uint32_t current_day) const {

ConditionValidator::Result result(true);

- result.model_ready_ok = model.IsReady();

+ result.event_model_ready_ok = model.IsReady();

result.currently_showing_ok = !currently_showing_;

result.feature_enabled_ok = base::FeatureList::IsEnabled(feature);

result.config_ok = config.valid;