Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Side by Side Diff: components/feature_engagement_tracker/internal/persistent_store.cc

Issue 2911123003: Metrics for feature engagement tracker. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/feature_engagement_tracker/internal/persistent_store.h" 5 #include "components/feature_engagement_tracker/internal/persistent_store.h"
6 6
7 #include <vector> 7 #include <vector>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/memory/ptr_util.h" 10 #include "base/memory/ptr_util.h"
11 #include "components/feature_engagement_tracker/internal/stats.h"
11 12
12 namespace feature_engagement_tracker { 13 namespace feature_engagement_tracker {
13 namespace { 14 namespace {
14 // Corresponds to a UMA suffix "LevelDBOpenResults" in histograms.xml. 15 // Corresponds to a UMA suffix "LevelDBOpenResults" in histograms.xml.
15 // Please do not change. 16 // Please do not change.
16 const char kDatabaseUMAName[] = "FeatureEngagementTrackerEventStore"; 17 const char kDatabaseUMAName[] = "FeatureEngagementTrackerEventStore";
17 18
18 using KeyEventPair = std::pair<std::string, Event>; 19 using KeyEventPair = std::pair<std::string, Event>;
19 using KeyEventList = std::vector<KeyEventPair>; 20 using KeyEventList = std::vector<KeyEventPair>;
20 21
21 void NoopUpdateCallback(bool success) {} 22 void NoopUpdateCallback(bool success) {
23 stats::RecordDbUpdate(success, stats::StoreType::EVENTS_STORE);
24 }
25
22 } // namespace 26 } // namespace
23 27
24 PersistentStore::PersistentStore( 28 PersistentStore::PersistentStore(
25 const base::FilePath& storage_dir, 29 const base::FilePath& storage_dir,
26 std::unique_ptr<leveldb_proto::ProtoDatabase<Event>> db) 30 std::unique_ptr<leveldb_proto::ProtoDatabase<Event>> db)
27 : storage_dir_(storage_dir), 31 : storage_dir_(storage_dir),
28 db_(std::move(db)), 32 db_(std::move(db)),
29 ready_(false), 33 ready_(false),
30 weak_ptr_factory_(this) {} 34 weak_ptr_factory_(this) {}
31 35
32 PersistentStore::~PersistentStore() = default; 36 PersistentStore::~PersistentStore() = default;
33 37
34 void PersistentStore::Load(const OnLoadedCallback& callback) { 38 void PersistentStore::Load(const OnLoadedCallback& callback) {
35 DCHECK(!ready_); 39 DCHECK(!ready_);
36 40
37 db_->Init(kDatabaseUMAName, storage_dir_, 41 db_->Init(kDatabaseUMAName, storage_dir_,
38 base::Bind(&PersistentStore::OnInitComplete, 42 base::Bind(&PersistentStore::OnInitComplete,
39 weak_ptr_factory_.GetWeakPtr(), callback)); 43 weak_ptr_factory_.GetWeakPtr(), callback));
40 } 44 }
41 45
42 bool PersistentStore::IsReady() const { 46 bool PersistentStore::IsReady() const {
43 return ready_; 47 return ready_;
44 } 48 }
45 49
46 void PersistentStore::WriteEvent(const Event& event) { 50 void PersistentStore::WriteEvent(const Event& event) {
47 DCHECK(IsReady()); 51 DCHECK(IsReady());
48 std::unique_ptr<KeyEventList> entries = base::MakeUnique<KeyEventList>(); 52 std::unique_ptr<KeyEventList> entries = base::MakeUnique<KeyEventList>();
49 entries->push_back(KeyEventPair(event.name(), event)); 53 entries->push_back(KeyEventPair(event.name(), event));
50 54
51 // TODO(dtrainor, nyquist): Consider tracking failures here and storing UMA.
52 db_->UpdateEntries(std::move(entries), 55 db_->UpdateEntries(std::move(entries),
53 base::MakeUnique<std::vector<std::string>>(), 56 base::MakeUnique<std::vector<std::string>>(),
54 base::Bind(&NoopUpdateCallback)); 57 base::Bind(&NoopUpdateCallback));
55 } 58 }
56 59
57 void PersistentStore::DeleteEvent(const std::string& event_name) { 60 void PersistentStore::DeleteEvent(const std::string& event_name) {
58 DCHECK(IsReady()); 61 DCHECK(IsReady());
59 auto deletes = base::MakeUnique<std::vector<std::string>>(); 62 auto deletes = base::MakeUnique<std::vector<std::string>>();
60 deletes->push_back(event_name); 63 deletes->push_back(event_name);
61 64
62 // TODO(dtrainor, nyquist): Consider tracking failures here and storing UMA.
63 db_->UpdateEntries(base::MakeUnique<KeyEventList>(), std::move(deletes), 65 db_->UpdateEntries(base::MakeUnique<KeyEventList>(), std::move(deletes),
64 base::Bind(&NoopUpdateCallback)); 66 base::Bind(&NoopUpdateCallback));
65 } 67 }
66 68
67 void PersistentStore::OnInitComplete(const OnLoadedCallback& callback, 69 void PersistentStore::OnInitComplete(const OnLoadedCallback& callback,
68 bool success) { 70 bool success) {
71 stats::RecordDbInitEvent(success, stats::StoreType::EVENTS_STORE);
72
69 if (!success) { 73 if (!success) {
70 callback.Run(false, base::MakeUnique<std::vector<Event>>()); 74 callback.Run(false, base::MakeUnique<std::vector<Event>>());
71 return; 75 return;
72 } 76 }
73 77
74 db_->LoadEntries(base::Bind(&PersistentStore::OnLoadComplete, 78 db_->LoadEntries(base::Bind(&PersistentStore::OnLoadComplete,
75 weak_ptr_factory_.GetWeakPtr(), callback)); 79 weak_ptr_factory_.GetWeakPtr(), callback));
76 } 80 }
77 81
78 void PersistentStore::OnLoadComplete( 82 void PersistentStore::OnLoadComplete(
79 const OnLoadedCallback& callback, 83 const OnLoadedCallback& callback,
80 bool success, 84 bool success,
81 std::unique_ptr<std::vector<Event>> entries) { 85 std::unique_ptr<std::vector<Event>> entries) {
86 stats::RecordEventDbLoadEvent(success, *entries.get());
82 ready_ = success; 87 ready_ = success;
83 callback.Run(success, std::move(entries)); 88 callback.Run(success, std::move(entries));
84 } 89 }
85 90
86 } // namespace feature_engagement_tracker 91 } // namespace feature_engagement_tracker
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698