Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 2897243002: Revert of [Page Load Metrics] PageLoadMetrics Mojofication. (Closed)

Created:
3 years, 7 months ago by lpy
Modified:
3 years, 7 months ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, csharrison+watch_chromium.org, darin (slow to review), loading-reviews+metrics_chromium.org, qsr+mojo_chromium.org, speed-metrics-reviews_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Page Load Metrics] PageLoadMetrics Mojofication. (patchset #19 id:520001 of https://codereview.chromium.org/2823523003/ ) Reason for revert: Revert this patch due to windows crash and we are at the corner of branch day. Original issue's description: > [Page Load Metrics] PageLoadMetrics Mojofication. > > This patch > > 1. Adds mojo pipeline; > 2. Adds Finch Trial check to toggle mojo IPC; > 3. Modifies browser tests to be parameterized for mojo IPC. > > The PageLoadMetrics mojo interface defines a UpdateTiming interface that is > implemented by MetricsWebContentsObserver. PageLoadMetrics is sensitive to IPC > ordering, thus MetricsWebContentsObserver holds a WebContentsFrameBindingSet > that is used to bind associated interface together with RenderFrameHost, and it > shares the legacy IPC channel so that we make sure we don't break IPC ordering. > > BUG=709259, 712915 > > Review-Url: https://codereview.chromium.org/2823523003 > Cr-Commit-Position: refs/heads/master@{#473663} > Committed: https://chromium.googlesource.com/chromium/src/+/a44af8f558766ab8c6b65fff8be4b1ef1a5f903b TBR=bmcquade@chromium.org,rkaplow@chromium.org,rockot@chromium.org,tsepez@chromium.org,zhenw@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=709259, 712915

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+235 lines, -444 lines) Patch
M chrome/browser/chrome_content_browser_manifest_overlay.json View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/page_load_metrics/metrics_web_contents_observer.h View 6 chunks +1 line, -19 lines 0 comments Download
M chrome/browser/page_load_metrics/metrics_web_contents_observer.cc View 5 chunks +2 lines, -28 lines 0 comments Download
M chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc View 35 chunks +39 lines, -126 lines 0 comments Download
M chrome/common/chrome_features.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/chrome_features.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/page_load_metrics/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/page_load_metrics/page_load_metrics.mojom View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
A chrome/renderer/page_load_metrics/fake_page_timing_metrics_ipc_sender.h View 1 chunk +73 lines, -0 lines 0 comments Download
A chrome/renderer/page_load_metrics/fake_page_timing_metrics_ipc_sender.cc View 1 chunk +54 lines, -0 lines 0 comments Download
D chrome/renderer/page_load_metrics/fake_page_timing_sender.h View 1 chunk +0 lines, -75 lines 0 comments Download
D chrome/renderer/page_load_metrics/fake_page_timing_sender.cc View 1 chunk +0 lines, -53 lines 0 comments Download
M chrome/renderer/page_load_metrics/metrics_render_frame_observer.h View 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc View 4 chunks +1 line, -55 lines 0 comments Download
M chrome/renderer/page_load_metrics/metrics_render_frame_observer_unittest.cc View 4 chunks +9 lines, -7 lines 0 comments Download
M chrome/renderer/page_load_metrics/page_timing_metrics_sender.h View 2 chunks +9 lines, -5 lines 0 comments Download
M chrome/renderer/page_load_metrics/page_timing_metrics_sender.cc View 4 chunks +11 lines, -7 lines 0 comments Download
M chrome/renderer/page_load_metrics/page_timing_metrics_sender_unittest.cc View 7 chunks +29 lines, -28 lines 0 comments Download
D chrome/renderer/page_load_metrics/page_timing_sender.h View 1 chunk +0 lines, -23 lines 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
lpy
Created Revert of [Page Load Metrics] PageLoadMetrics Mojofication.
3 years, 7 months ago (2017-05-24 05:49:55 UTC) #2
Bryan McQuade
On 2017/05/24 at 05:49:55, lpy wrote: > Created Revert of [Page Load Metrics] PageLoadMetrics Mojofication. ...
3 years, 7 months ago (2017-05-24 16:13:04 UTC) #8
Bryan McQuade
On 2017/05/24 at 16:13:04, Bryan McQuade wrote: > On 2017/05/24 at 05:49:55, lpy wrote: > ...
3 years, 7 months ago (2017-05-24 17:20:05 UTC) #9
lpy
3 years, 7 months ago (2017-05-24 17:20:28 UTC) #10
Message was sent while issue was closed.
On 2017/05/24 17:20:05, Bryan McQuade wrote:
> On 2017/05/24 at 16:13:04, Bryan McQuade wrote:
> > On 2017/05/24 at 05:49:55, lpy wrote:
> > > Created Revert of [Page Load Metrics] PageLoadMetrics Mojofication.
> > 
> > let's turn off the field trial, instead of reverting the change.
> 
> Field trial has been disabled, so there is no need to land this revert. I'll
> close this out.

Thank you.

Powered by Google App Engine
This is Rietveld 408576698