Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1072)

Unified Diff: chrome/renderer/page_load_metrics/fake_page_timing_metrics_ipc_sender.h

Issue 2897243002: Revert of [Page Load Metrics] PageLoadMetrics Mojofication. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/BUILD.gn ('k') | chrome/renderer/page_load_metrics/fake_page_timing_metrics_ipc_sender.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/page_load_metrics/fake_page_timing_metrics_ipc_sender.h
diff --git a/chrome/renderer/page_load_metrics/fake_page_timing_metrics_ipc_sender.h b/chrome/renderer/page_load_metrics/fake_page_timing_metrics_ipc_sender.h
new file mode 100644
index 0000000000000000000000000000000000000000..91befdcef6b8065aa9bdc1cd525c1bc8f6c604be
--- /dev/null
+++ b/chrome/renderer/page_load_metrics/fake_page_timing_metrics_ipc_sender.h
@@ -0,0 +1,73 @@
+// Copyright (c) 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_RENDERER_PAGE_LOAD_METRICS_FAKE_PAGE_TIMING_METRICS_IPC_SENDER_H_
+#define CHROME_RENDERER_PAGE_LOAD_METRICS_FAKE_PAGE_TIMING_METRICS_IPC_SENDER_H_
+
+#include <vector>
+
+#include "chrome/common/page_load_metrics/page_load_timing.h"
+#include "ipc/ipc_sender.h"
+
+namespace IPC {
+class Message;
+}
+
+namespace page_load_metrics {
+
+// IPC::Sender implementation for use in tests. Allows for setting and verifying
+// basic expectations when sending PageLoadTiming IPCs. By default,
+// FakePageTimingMetricsIPCSender will verify that expected and actual
+// PageLoadTimings match on each invocation to ExpectPageLoadTiming() and
+// Send(), as well as in the destructor. Tests can force additional validations
+// by calling VerifyExpectedTimings.
+//
+// Expected PageLoadTimings are specified via ExpectPageLoadTiming, and actual
+// PageLoadTimings are dispatched through Send(). When Send() is called, we
+// verify that the actual PageLoadTimings dipatched through Send() match the
+// expected PageLoadTimings provided via ExpectPageLoadTiming.
+//
+// Normally, gmock would be used in place of this class, but gmock is not
+// compatible with structures that use aligned memory, and PageLoadTiming will
+// soon use base::Optional which uses aligned memory, so we're forced to roll
+// our own implementation here. See
+// https://groups.google.com/forum/#!topic/googletestframework/W-Hud3j_c6I for
+// more details.
+class FakePageTimingMetricsIPCSender : public IPC::Sender {
+ public:
+ FakePageTimingMetricsIPCSender();
+ ~FakePageTimingMetricsIPCSender() override;
+
+ // Implementation of IPC::Sender. PageLoadMetricsMsg_TimingUpdated IPCs that
+ // send updated PageLoadTimings should be dispatched through this method. This
+ // method will verify that all PageLoadTiming update IPCs dispatched so far
+ // match with the expected PageLoadTimings passed to ExpectPageLoadTiming.
+ bool Send(IPC::Message* message) override;
+
+ // PageLoadTimings that are expected to be sent through Send() should be
+ // passed to ExpectPageLoadTiming.
+ void ExpectPageLoadTiming(const mojom::PageLoadTiming& timing);
+
+ // Forces verification that actual timings sent through Send match
+ // expected timings provided via ExpectPageLoadTiming.
+ void VerifyExpectedTimings() const;
+
+ const std::vector<mojom::PageLoadTimingPtr>& expected_timings() const {
+ return expected_timings_;
+ }
+ const std::vector<mojom::PageLoadTimingPtr>& actual_timings() const {
+ return actual_timings_;
+ }
+
+ private:
+ void OnTimingUpdated(const mojom::PageLoadTiming& timing,
+ mojom::PageLoadMetadata metadata);
+
+ std::vector<mojom::PageLoadTimingPtr> expected_timings_;
+ std::vector<mojom::PageLoadTimingPtr> actual_timings_;
+};
+
+} // namespace page_load_metrics
+
+#endif // CHROME_RENDERER_PAGE_LOAD_METRICS_FAKE_PAGE_TIMING_METRICS_IPC_SENDER_H_
« no previous file with comments | « chrome/renderer/BUILD.gn ('k') | chrome/renderer/page_load_metrics/fake_page_timing_metrics_ipc_sender.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698