Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(910)

Side by Side Diff: chrome/renderer/page_load_metrics/page_timing_metrics_sender.cc

Issue 2897243002: Revert of [Page Load Metrics] PageLoadMetrics Mojofication. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/renderer/page_load_metrics/page_timing_metrics_sender.h" 5 #include "chrome/renderer/page_load_metrics/page_timing_metrics_sender.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/callback.h" 9 #include "base/callback.h"
10 #include "base/time/time.h" 10 #include "base/time/time.h"
11 #include "base/timer/timer.h" 11 #include "base/timer/timer.h"
12 #include "chrome/renderer/page_load_metrics/page_timing_sender.h" 12 #include "chrome/common/page_load_metrics/page_load_metrics_messages.h"
13 #include "ipc/ipc_sender.h"
13 14
14 namespace page_load_metrics { 15 namespace page_load_metrics {
15 16
16 namespace { 17 namespace {
17 const int kInitialTimerDelayMillis = 50; 18 const int kInitialTimerDelayMillis = 50;
18 const int kTimerDelayMillis = 1000; 19 const int kTimerDelayMillis = 1000;
19 } // namespace 20 } // namespace
20 21
21 PageTimingMetricsSender::PageTimingMetricsSender( 22 PageTimingMetricsSender::PageTimingMetricsSender(
22 std::unique_ptr<PageTimingSender> sender, 23 IPC::Sender* ipc_sender,
24 int routing_id,
23 std::unique_ptr<base::Timer> timer, 25 std::unique_ptr<base::Timer> timer,
24 mojom::PageLoadTimingPtr initial_timing) 26 mojom::PageLoadTimingPtr initial_timing)
25 : sender_(std::move(sender)), 27 : ipc_sender_(ipc_sender),
28 routing_id_(routing_id),
26 timer_(std::move(timer)), 29 timer_(std::move(timer)),
27 last_timing_(std::move(initial_timing)), 30 last_timing_(std::move(initial_timing)),
28 metadata_(mojom::PageLoadMetadata::New()) { 31 metadata_(mojom::PageLoadMetadata()) {
29 if (!IsEmpty(*last_timing_)) { 32 if (!IsEmpty(*last_timing_)) {
30 EnsureSendTimer(); 33 EnsureSendTimer();
31 } 34 }
32 } 35 }
33 36
34 // On destruction, we want to send any data we have if we have a timer 37 // On destruction, we want to send any data we have if we have a timer
35 // currently running (and thus are talking to a browser process) 38 // currently running (and thus are talking to a browser process)
36 PageTimingMetricsSender::~PageTimingMetricsSender() { 39 PageTimingMetricsSender::~PageTimingMetricsSender() {
37 if (timer_->IsRunning()) { 40 if (timer_->IsRunning()) {
38 timer_->Stop(); 41 timer_->Stop();
39 SendNow(); 42 SendNow();
40 } 43 }
41 } 44 }
42 45
43 void PageTimingMetricsSender::DidObserveLoadingBehavior( 46 void PageTimingMetricsSender::DidObserveLoadingBehavior(
44 blink::WebLoadingBehaviorFlag behavior) { 47 blink::WebLoadingBehaviorFlag behavior) {
45 if (behavior & metadata_->behavior_flags) 48 if (behavior & metadata_.behavior_flags)
46 return; 49 return;
47 metadata_->behavior_flags |= behavior; 50 metadata_.behavior_flags |= behavior;
48 EnsureSendTimer(); 51 EnsureSendTimer();
49 } 52 }
50 53
51 void PageTimingMetricsSender::Send(mojom::PageLoadTimingPtr timing) { 54 void PageTimingMetricsSender::Send(mojom::PageLoadTimingPtr timing) {
52 if (last_timing_->Equals(*timing)) 55 if (last_timing_->Equals(*timing))
53 return; 56 return;
54 57
55 // We want to make sure that each PageTimingMetricsSender is associated 58 // We want to make sure that each PageTimingMetricsSender is associated
56 // with a distinct page navigation. Because we reset the object on commit, 59 // with a distinct page navigation. Because we reset the object on commit,
57 // we can trash last_timing_ on a provisional load before SendNow() fires. 60 // we can trash last_timing_ on a provisional load before SendNow() fires.
(...skipping 13 matching lines...) Expand all
71 int delay_ms = 74 int delay_ms =
72 have_sent_ipc_ ? kTimerDelayMillis : kInitialTimerDelayMillis; 75 have_sent_ipc_ ? kTimerDelayMillis : kInitialTimerDelayMillis;
73 timer_->Start( 76 timer_->Start(
74 FROM_HERE, base::TimeDelta::FromMilliseconds(delay_ms), 77 FROM_HERE, base::TimeDelta::FromMilliseconds(delay_ms),
75 base::Bind(&PageTimingMetricsSender::SendNow, base::Unretained(this))); 78 base::Bind(&PageTimingMetricsSender::SendNow, base::Unretained(this)));
76 } 79 }
77 } 80 }
78 81
79 void PageTimingMetricsSender::SendNow() { 82 void PageTimingMetricsSender::SendNow() {
80 have_sent_ipc_ = true; 83 have_sent_ipc_ = true;
81 sender_->SendTiming(last_timing_, metadata_); 84 ipc_sender_->Send(new PageLoadMetricsMsg_TimingUpdated(
85 routing_id_, *last_timing_, metadata_));
82 } 86 }
83 87
84 } // namespace page_load_metrics 88 } // namespace page_load_metrics
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698